Clean up strategy on signing servers is based on age of artefacts, but should be based on available disk space

RESOLVED WONTFIX

Status

Release Engineering
General
RESOLVED WONTFIX
4 years ago
a year ago

People

(Reporter: pmoore, Assigned: coop)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
See:
https://github.com/mozilla/build-tools/blob/master/lib/python/signing/server.py#L408 -> https://github.com/mozilla/build-tools/blob/master/lib/python/signing/server.py#L331

The reason this is bad, is that when we have a lot of releases all at once, we can quickly use up available disk space.

Ideally the algorithm should keep a certain amount of disk space free, regardless of how old the artefacts are.
We should probably factor in age to a degree, at least to the point of "don't delete things that are less than X min old", where X is higher than the amount of time it takes to sign something and the slave to get it. Otherwise we risk deleting artifacts that are still needed.
(Assignee)

Updated

3 years ago
Assignee: nobody → coop
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Created attachment 8546685 [details] [diff] [review]
[puppet] Keep signed files for 4 hours instead of 8
Attachment #8546685 - Flags: review?(bhearsum)
Attachment #8546685 - Flags: review?(bhearsum) → review+
(Reporter)

Comment 3

3 years ago
Let's keep this bug open for the general problem, since in bug 1072274 we went from 12 hours to 8 hours, in this bug we are now going from 8 hours to 4 hours, and at some point we may need to go from 4 hours to 2 hours unless we switch the underlying algorithm.
(Assignee)

Comment 4

3 years ago
Comment on attachment 8546685 [details] [diff] [review]
[puppet] Keep signed files for 4 hours instead of 8

Review of attachment 8546685 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/puppet/rev/bda33a2528bf
Attachment #8546685 - Flags: checked-in+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
Component: Tools → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.