1104864 - New GitHub account ignores user preference to use unconfirmed email address

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Sign-in, defect)

Description

[Stephanie Hobson [:shobson]]

Using a GitHub account that is not connected to MDN:

Steps to reproduce:
1) Sign in using GitHub
2) On the Create an Account page for the email address choose "other" and enter an unconfirmed email address not associated with any other MDN account
3) Finish account creation

What happens:
- Viewing the users/account/email page shows MDN has picked one of the confirmed email addresses from GitHub as the primary address.
- No email to confirm the user's preferred email address is sent.
- Once the user's preferred email address is confirmed it is not made the primary address

What should have happened:
- We should have respected the user's expressed preference

Two solutions:
1) We do not ignore the user's preference, if they enter an "other" address we send an email to confirm the email address and do not allow them to log in until they have done so.
2) We remove the "other" field from the account creation form and force them to pick a confirmed email address from gitHub (this does not prevent them from changing it later on their profile)

Comment 1

[Jannis Leidel [:jezdez]]

https://github.com/mozilla/kuma/pull/2945

Comment 2

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/0e840b97264b9517909413a08c6e40c3d456d0f6
Fix bug 1104864 - Correctly handle "other" email.

This fixes an actual broken piece of the custom email address signup scheme.

https://github.com/mozilla/kuma/commit/f94a76aba1c9a34d2f8cd0aaa74c45b0d9213855
Merge pull request #2945 from jezdez/bug1104864

Fix bug 1104864 - Correctly handle "other" email.