Closed
Bug 11049
Opened 25 years ago
Closed 24 years ago
UNIX Movemail
Categories
(MailNews Core :: Backend, defect, P3)
MailNews Core
Backend
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0
People
(Reporter: sspitzer, Assigned: adam)
References
(Blocks 1 open bug)
Details
(Keywords: helpwanted)
Attachments
(4 files)
7.90 KB,
patch
|
Details | Diff | Splinter Review | |
4.53 KB,
application/octet-stream
|
Details | |
7.83 KB,
patch
|
Details | Diff | Splinter Review | |
30.05 KB,
application/octet-stream
|
Details |
see this thread: news://news.mozilla.org/375D61D1.B3CD128F%40informatik.med.uni-giessen.de read this: http://lxr.mozilla.org/seamonkey/source/mailnews/movemail/README old builtin movemail code from 4.x in http://lxr.mozilla.org/seamonkey/source/mailnews/movemail/src/movemail.c
Reporter | ||
Updated•25 years ago
|
Whiteboard: HELP WANTED
Target Milestone: M15
Reporter | ||
Comment 1•25 years ago
|
||
marking m15
Comment 2•25 years ago
|
||
Bulk-resolving requests for enhancement as "later" to get them off the Seamonkey bug tracking radar. Even though these bugs are not "open" in bugzilla, we welcome fixes and improvements in these areas at any time. Mail/news RFEs continue to be tracked on http://www.mozilla.org/mailnews/jobs.html
Comment 3•25 years ago
|
||
Reopen mail/news HELP WANTED bugs and reassign to nobody@mozilla.org
Reporter | ||
Comment 4•25 years ago
|
||
#12801 was the bug where I divorced local mail and pop3. now that bug #12801 is fixed, doing movemail should be much easier.
Updated•25 years ago
|
Keywords: helpwanted
Updated•25 years ago
|
Summary: [HELP WANTED] UNIX Movemail → UNIX Movemail
Whiteboard: HELP WANTED
Target Milestone: M15
Assignee | ||
Comment 5•25 years ago
|
||
I'm trying to implement this, since no-one else has picked it up to date. I've assigned it to myself although I won't be extremely upset if someone else with more free time wishes to work in parallel and beats me to a working implementation. =)
Status: NEW → ASSIGNED
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 8•25 years ago
|
||
I have a basic moronic implementation sort of working in my tree now. At least, it's being tickled in the right places. I'm having some trouble though, chiefly that I can't identify the mechanism by which I should feed the spool (or at a pinch a message at a time) to the right mailbox and have Mozilla become aware of the new messages/headers etc. So currently I have something very crude hanging on GetNewMail which sidesteps a lot of stuff and simply appends the spool file wholesale to a specific folder in the correct mozilla mail directory. Even this isn't quite doing the trick, since (understandably) mozilla does not build an index for this folder until it is restarted, and even then usually crashes upon opening one of these messages. I need some more hand-holding on #mozilla (nick:Aspirin) or in email, I suspect. --Adam
Reporter | ||
Comment 9•25 years ago
|
||
adamn, does http://lxr.mozilla.org/seamonkey/source/mailnews/movemail/src/movemail.c answer of you questions? if not, you can find me in #mozilla as sspitzer or sspitzer_msg_me
Assignee | ||
Comment 10•25 years ago
|
||
I've read this code but I was under the impression that the piece that I'm actually stuck on, which is having my messages consumed by Mozilla and excreted into a folder through the 'right' interface, would not resemble the solution in this classic-codebase code. Please correct me if I'm wrong. To clarify... my main blocking point right now is figuring out the mechanism by which I should feed this mbox, either wholesale or a message at a time, into the right folders. There must be a magic interface for this which also handles message filtering etc., but even after reading through the POP/POP-protocol code it is not clear to me where the messages are being produced and consumed. Thanks, --Adam
Comment 11•25 years ago
|
||
You probably want to be looking at mailnews/local/nsParseMailbox.cpp - that's how mail messages get streamed into the inbox, and how the filtering code gets a crack at the incoming messages. nsPop3Sink::BeginMailDelivery(PRBool* aBool) creates a mailbox parser and streams data into it. Let me know if you have more questions after looking at this code.
Comment 12•25 years ago
|
||
Are you talking about that fact that messages aren't showing up in the thread pane of an open folder? If so, the way this is hooked up for all of the other protocols is that each folder has a db. When new messages come in, the db calls various nsIDBChangeListener methods. The folder is a listener and converts the results to something that it can send onto the ui. The parse mailbox code is where the updating of the db happens.
Assignee | ||
Comment 13•25 years ago
|
||
Thanks, that was a big help. I think I have the mailbox population pretty much licked now. My next problem is that messages deposited in the Inbox by the movemail module are unopenable -- clicking on the message summary in the summary pane does not open the message. Something is *trying* to do it, since a mailbox_message://blah/Inbox#0 URL is being displayed as a debugging message, but it's not actually working. It's not due to the actual contents of the mailbox trying to be opened, as moving a working pop-originated Inbox and its summary-file over the movemail-account ones still renders the messages unopenable. I'll chew on that one some more, though if anyone instinctively has a strong idea what's causing it then I'd welcome further input. Cheers, --Adam
Assignee | ||
Comment 14•25 years ago
|
||
Right, I have a working Movemail implementation now. I'll attach it here after some clean-up. --Adam
Reporter | ||
Comment 15•25 years ago
|
||
excellent! when it comes time for a reviewer / tester, I'll do it.
Assignee | ||
Comment 16•25 years ago
|
||
Initial patches submitted to netscape.public.mozilla.mail-news and netscape.public.mozilla.patches, Subject: "[patch] Movemail support." --Adam
Reporter | ||
Comment 17•25 years ago
|
||
I hope to try out and check in adam's fixes soon, before it suffers bit rot. I will have to make some changes (see news://news.mozilla.org/38C2ED30.E22D0E6E%40netscape.com) marking m15.
Target Milestone: M15
Comment 18•25 years ago
|
||
Question: Does this "movemail" implement "movemail IMAP-style" (= movemail leaves mail in /var/mail/$USER, adds references to it's database and marks mail in /var/mail/$USER as "read" (is that possible ?)) ? This would allow users to use the mailer of their choice (like pine, /usr/ucb/from, dtmail etc.) to read/send messages...
Comment 19•24 years ago
|
||
Mass moving to M16 to get these off the M15 radar. Please let me know if this is really an M15 stopper.
Target Milestone: M15 → M16
Assignee | ||
Comment 20•24 years ago
|
||
In short answer to Roland's question, 'No.' As an almost-equally-brief progress update, I have movemail support working again in my local tree after letting it bitrot w.r.t. the main tree for too long. Will submit a new patch when I have time. --Adam
Comment 21•24 years ago
|
||
Is there someone interested in the "movemail IMAP-style" idea ?
Assignee | ||
Comment 22•24 years ago
|
||
Assignee | ||
Comment 23•24 years ago
|
||
Assignee | ||
Comment 24•24 years ago
|
||
Here are the changes for embreonic Movemail support relative to current CVS. They are merely an update of the previous patches which formerly broke over time due to interface and general code drift. The update still doesn't 'do' any more than the previous patches (eg. still doesn't write/truncate the spool file, so concurrent 'get new mail's will get the same mail multiple times).
Comment 25•24 years ago
|
||
*** Bug 7836 has been marked as a duplicate of this bug. ***
Comment 26•24 years ago
|
||
M16 has been out for a while now, these bugs target milestones need to be updated.
Comment 27•24 years ago
|
||
What's the status of this bug/RFE ? Is "movemail" in Mozilla working - if YES the only "remaining" issue would be to update the "Create new mailnews-account wizard"...
Reporter | ||
Comment 28•24 years ago
|
||
sad to say, movemail is not working in mozilla. I haven't had the cycles to help adam finish it up. this will probably slip to 6.1
Comment 29•24 years ago
|
||
Is there a change to "bump"-up the priority of this RFE (well, we have 12 votes for this bug...) ? Os is there a way we can help ?
Assignee | ||
Comment 30•24 years ago
|
||
The status is that the backend mechanics need only a little more twiddling to be in fine working order, but the integration with the core needs to be done in a more intelligent and flexible way than we've approached the problem to date, to address various issues -- and this is beyond my available time and knowledge at this point with respect to the rapidly-diminishing window onto 6.0. I might find time to crib some catagorization code from elsewhere in the codebase, but I don't know how big a job that'd be (Seth, any idea?). I'll report any change of status right here.
Reporter | ||
Comment 31•24 years ago
|
||
help is always appreciated. the big things to do are: 1) restore adam's work. it's been a while, there has probably been some bit rot as the mailnews code has probably shifted. 2) write/truncate the spool file (see adam's comments below) 3) making the ui modular so movemail only shows up on unix see news://news.mozilla.org/38C2ED30.E22D0E6E%40netscape.com most of the work is in task #3.
Comment 32•24 years ago
|
||
I was thinking about the dynamic issue - an easy thing to do might be to use dynamic overlays to insert the movemail option into the account wizard page - a tiny bit less work, and a whole lot less risk.
Reporter | ||
Comment 33•24 years ago
|
||
alecf: how about the account manager?
Comment 34•24 years ago
|
||
account manager wouldn't need anything more than the extra entry in the .properties file to verbosely display "Movemail" in the server pane.
Assignee | ||
Comment 35•24 years ago
|
||
I've updated the movemail code again to counter bitrot/interface-rot. When I have the time to perform at least perfunctory testing I'll attach the new patches. Treading water. --Adam
Comment 36•24 years ago
|
||
*** Bug 45979 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 37•24 years ago
|
||
My local tree is patched up to build with respect to trunk driftage again. Untested for a while -- will post a fresh patch when I have time to test.
Assignee | ||
Comment 38•24 years ago
|
||
Assignee | ||
Comment 39•24 years ago
|
||
Assignee | ||
Comment 40•24 years ago
|
||
Well, my local tree still appears to be working w.r.t. movemail support so I've attached a fresh set of patches and a tarball of new files.
Assignee | ||
Comment 41•24 years ago
|
||
Does anyone have suggestions concerning the: a) Easiest b) Right ways of integrating with the front-end (so that only UNIXoids get the movemail options -- at the moment these options are given to all users using these patches)? AFAICS that's the main higher-level thing holding this up -- right? I'd also like opinions on whether this has majorly missed the mozilla1.0 boat, and whether either option a) or b) above would assist in swimming the channel. It's definitely missed NS6.0 (correct?).
Target Milestone: M16 → M30
Assignee | ||
Comment 42•24 years ago
|
||
(n.b. when I say 'holding this up' I mean 'keeping this out of CVS', I think.)
Comment 43•24 years ago
|
||
Adding 4xp keyword. This really needs to be fixed ASAP it was a well used feature in Netscape Communicator and previous versions of Netscape. If people get their mail delivered to their UNIX mailbox then movemail provides the only option for them to read their mail using Netscape/Mozilla. Therefore we're limiting the acceptance of Mozilla as a UNIX mailreader to people who get their mail through POP3 or IMAP. Most UNIX users want to rid their systems of Netscape 4.x don't let something as simple as this stop them.
Keywords: 4xp
Reporter | ||
Comment 44•24 years ago
|
||
adam, first thanks for being more than patient with me for not getting this in yet. movemail has missed the NS 6.0 boat. It has not missed the Mozilla 1.0 boat. I would like to redeem myself by helping you finish this work and getting it checked into the trunk. We will have to do some work to make it so the UI only shows up for the UNIX builds. But that should not be too bad. I'll go talk to my manager and see if I can get some time to work on this on the trunk. I'd hate to see your movemail work bit rot (again.)
Comment 45•24 years ago
|
||
I think we can check in all the backend changes safely (onto the trunk) and wory about the frontend in a little while. As for getting the front end correct, we need to start using categories to represent the server types. Then, we can populate the frontend (the wizard) with a list of server types. My suggestion is to reflect it into RDF and then construct the combo box with a <template> - This will also allow us (at some point) to add the same combo box to change the server type in the account manager.
Assignee | ||
Comment 46•24 years ago
|
||
Thanks again seth and alecf! Let me know what is within my humble powers to help on this. --Adam
Reporter | ||
Comment 48•24 years ago
|
||
I spent my saturday and landed adam's patch on to the trunk. (thanks for providing a fresh and easy to land patch). movemail works for me on linux. I set up an internal movemail account in 4.x, and migrated to 6.0 and was able to read mail! as we know, there is a bunch of UI missing, but that is another bug. I'll go log some bugs on that. I'll also ask for a new "movemail" module and bugzilla category (under mailnews). adam and I will be the on the hook for it. marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 49•24 years ago
|
||
verified. people are using movemail on the trunk.
Status: RESOLVED → VERIFIED
Comment 50•24 years ago
|
||
Bug 27853 has been marked as a "duplicate" of bug 56669. Is it OK with replacing "Bug 11049 blocks bug 27853" with 56669 ?
Comment 51•23 years ago
|
||
*** Bug 94937 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
Comment hidden (collapsed) |
You need to log in
before you can comment on or make changes to this bug.
Description
•