Closed
Bug 1104925
Opened 9 years ago
Closed 9 years ago
Update Yahoo! Search Plugin for en-US
Categories
(Firefox :: Search, defect, P1)
Tracking
()
RESOLVED
FIXED
Firefox 37
People
(Reporter: kev, Assigned: kev)
References
Details
Attachments
(1 file)
20.60 KB,
patch
|
Gavin
:
review+
mconnor
:
feedback+
Gavin
:
approval-mozilla-beta+
Gavin
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
As part of the transition to Yahoo as default search, some attributes need to be modified for the en-US plugin (only). Note that the FR code will no longer be used, and the updated parameters are in the patch. The search suggests URL will remain unchanged.
Attachment #8528521 -
Flags: review?(gavin.sharp)
Attachment #8528521 -
Flags: feedback?(mconnor)
Updated•9 years ago
|
status-firefox34:
--- → affected
status-firefox35:
--- → affected
status-firefox36:
--- → affected
tracking-firefox34:
--- → +
tracking-firefox35:
--- → +
tracking-firefox36:
--- → +
Updated•9 years ago
|
Attachment #8528521 -
Flags: review?(gavin.sharp) → review+
Comment 2•9 years ago
|
||
Comment on attachment 8528521 [details] [diff] [review] Update Yahoo! for en-US Looks good to me.
Attachment #8528521 -
Flags: feedback?(mconnor) → feedback+
Updated•9 years ago
|
Attachment #8528521 -
Flags: approval-mozilla-release+
Attachment #8528521 -
Flags: approval-mozilla-beta+
Comment 5•9 years ago
|
||
Pushed a followup to fix the browser_yahoo* tests, no impact on releases: https://hg.mozilla.org/releases/mozilla-beta/rev/48cf662ee226 https://hg.mozilla.org/releases/mozilla-release/rev/48cf662ee226
Assignee: nobody → kev
Comment 6•9 years ago
|
||
Yahoo searches are redirected to https://search.yahoo.com/yhs/search?p= when searching from url bar, about:home, about:newtab and search toolbar. Firefox 34.0 build 2 Environments: Win 7 64-bit, Ubuntu 12.04 32-bit and Mac OSX 10.9.5
QA Contact: petruta.rasa
Assignee | ||
Comment 7•9 years ago
|
||
If you're outside the US, this is the expected result. There will be an override pushed in the coming days to the results page, but unless you're in the US at this time, geo-located redirects will occur.
Comment 8•9 years ago
|
||
Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b232181e8006 https://hg.mozilla.org/mozilla-central/rev/a7af8edcf64b
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox37:
--- → fixed
Resolution: --- → FIXED
Target Milestone: Firefox 34 → Firefox 37
Comment 9•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/75879febfc55 https://hg.mozilla.org/releases/mozilla-aurora/rev/b73bdd684787
You need to log in
before you can comment on or make changes to this bug.
Description
•