Closed Bug 1104931 Opened 5 years ago Closed 5 years ago

unify the 4 identical accountProvisioner.css files

Categories

(Thunderbird :: Theme, defect, minor)

35 Branch
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 37.0

People

(Reporter: mkmelin, Assigned: jsbruner)

Details

Attachments

(2 files, 1 obsolete file)

We have 4 different accountProvisioner.css (counting accountProvisioner-aero.css) files. Should be in a shared file. (Noticed in bug 910293, lets land that first)
OS: Linux → All
Hardware: x86_64 → All
Attached file MozReview Request: bz://1104931/JosiahOne (obsolete) β€”
Attachment #8528783 - Flags: review?(richard.marti)
/r/1049 - Bug 1104931 - Create a shared accountProvisioner.css file. r?=Paenglab

Pull down this commit:

hg pull review -r 54e894d930ba3900e6fc3f0e0396daf3d0a39666
I simply used our previous means of creating shared files (Keeping the files in their respected directories and simply @importing). Alternatively, we could point the .XUL files to the shared file directly, and remove the other files, but that doesn't seem worth the effort. If we ever needed to do platform specific styling we'd need to reintroduce the files, so I don't see a point.

Of course Richard, if you'd rather, I can do the alternative.
Assignee: nobody → josiah
Severity: normal → minor
Status: NEW → ASSIGNED
/r/1049 - Bug 1104931 - Create a shared accountProvisioner.css file. r?=Paenglab

Pull down this commit:

hg pull review -r 2e3f6545c4fc0db1daec4c19bdfaec637274ca59
https://reviewboard.mozilla.org/r/1049/#review585

This looks good, but two things:
* Please copy or move the accountProvisioner.css file to shared. Then we have the change history on this file.
* accountProvisioner-aero.css is not needed. Use the same file for XP and aero. Strange we had this two totally identic files on windows.
/r/1049 - Bug 1104931 - Create a shared accountProvisioner.css file. r?=Paenglab

Pull down this commit:

hg pull review -r 652d1a8d8e8f150e1153eae1df56ccf3a393e8b7
/r/1049 - Bug 1104931 - Create a shared accountProvisioner.css file. r?=Paenglab

Pull down this commit:

hg pull review -r 652d1a8d8e8f150e1153eae1df56ccf3a393e8b7
Richard, the patch I have locally *does* use hg copy, but for some reason pushes to reviewboard strip that. Just note that it will be a copy when I land.
https://reviewboard.mozilla.org/r/1049/#review607

When the file will be copied on check-in, then r+
Attachment #8528783 - Flags: review?(richard.marti) → review+
Attached patch Patch. β€” β€” Splinter Review
Here's the patch file with the hg copy stuff, for reference only.
Attachment #8529754 - Flags: review+
https://hg.mozilla.org/comm-central/rev/e7fc94abf423
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 37.0
Flags: in-testsuite-
Attachment #8528783 - Attachment is obsolete: true
Attachment #8618724 - Flags: review+
You need to log in before you can comment on or make changes to this bug.