1104931 - unify the 4 identical accountProvisioner.css files

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Magnus Melin [:mkmelin]]

We have 4 different accountProvisioner.css (counting accountProvisioner-aero.css) files. Should be in a shared file. (Noticed in bug 910293, lets land that first)

Comment 1

[Josiah Bruner [:jsbruner]]

Attachment: MozReview Request: bz://1104931/JosiahOne

Comment 2

[Josiah Bruner [:jsbruner]]

/r/1049 - Bug 1104931 - Create a shared accountProvisioner.css file. r?=Paenglab

Pull down this commit:

hg pull review -r 54e894d930ba3900e6fc3f0e0396daf3d0a39666

Comment 3

[Josiah Bruner [:jsbruner]]

I simply used our previous means of creating shared files (Keeping the files in their respected directories and simply @importing). Alternatively, we could point the .XUL files to the shared file directly, and remove the other files, but that doesn't seem worth the effort. If we ever needed to do platform specific styling we'd need to reintroduce the files, so I don't see a point.

Of course Richard, if you'd rather, I can do the alternative.

Comment 4

[Josiah Bruner [:jsbruner]]

/r/1049 - Bug 1104931 - Create a shared accountProvisioner.css file. r?=Paenglab

Pull down this commit:

hg pull review -r 2e3f6545c4fc0db1daec4c19bdfaec637274ca59

Comment 5

[Richard Marti (:Paenglab)]

https://reviewboard.mozilla.org/r/1049/#review585

This looks good, but two things:
* Please copy or move the accountProvisioner.css file to shared. Then we have the change history on this file.
* accountProvisioner-aero.css is not needed. Use the same file for XP and aero. Strange we had this two totally identic files on windows.

Comment 6

[Josiah Bruner [:jsbruner]]

/r/1049 - Bug 1104931 - Create a shared accountProvisioner.css file. r?=Paenglab

Pull down this commit:

hg pull review -r 652d1a8d8e8f150e1153eae1df56ccf3a393e8b7

Comment 7

[Josiah Bruner [:jsbruner]]

/r/1049 - Bug 1104931 - Create a shared accountProvisioner.css file. r?=Paenglab

Pull down this commit:

hg pull review -r 652d1a8d8e8f150e1153eae1df56ccf3a393e8b7

Comment 8

[Josiah Bruner [:jsbruner]]

Richard, the patch I have locally *does* use hg copy, but for some reason pushes to reviewboard strip that. Just note that it will be a copy when I land.

Comment 9

[Richard Marti (:Paenglab)]

https://reviewboard.mozilla.org/r/1049/#review607

When the file will be copied on check-in, then r+

Comment 10

[Richard Marti (:Paenglab)]

https://reviewboard.mozilla.org/r/1047/#review609

Ship It!

Comment 11

[Josiah Bruner [:jsbruner]]

Attachment: Patch.

Here's the patch file with the hg copy stuff, for reference only.

Comment 12

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/e7fc94abf423

Comment 14

[Josiah Bruner [:jsbruner]]

Attachment: MozReview Request: Bug 1104931 - Create a shared accountProvisioner.css file. r?=Paenglab