Closed Bug 1105038 Opened 5 years ago Closed 5 years ago

update clids for Yandex

Categories

(Mozilla Localizations :: Other, defect)

x86
macOS
defect
Not set

Tracking

(firefox34+ fixed, firefox35 fixed, firefox36 fixed)

RESOLVED FIXED
Tracking Status
firefox34 + fixed
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: mconnor, Assigned: mconnor)

Details

Attachments

(3 files, 1 obsolete file)

Attached patch ru.diff (obsolete) — Splinter Review
No description provided.
Locale: be / Belarusian, kk / Kazakh, ru / Russian
Attached patch be.diffSplinter Review
Attachment #8528645 - Attachment is obsolete: true
Attachment #8528653 - Flags: review?(gavin.sharp)
Attached patch kk.diffSplinter Review
Attachment #8528654 - Flags: review?(gavin.sharp)
Attached patch ru.diffSplinter Review
Attachment #8528655 - Flags: review?(gavin.sharp)
Comment on attachment 8528655 [details] [diff] [review]
ru.diff

I can't vouch that the "clid" values are correct for each "purpose", but I assume you've triple-checked those.
Attachment #8528655 - Flags: review?(gavin.sharp) → review+
Comment on attachment 8528654 [details] [diff] [review]
kk.diff

>diff --git a/browser/searchplugins/yandex.xml b/browser/searchplugins/yandex.xml

>-<SearchForm>http://www.yandex.kz/</SearchForm>
>-</SearchPlugin>
>+<SearchForm>https://www.yandex.kz/</SearchForm>
>+</SearchPlugin>
>\ No newline at end of file

Re-add the newline you removed.
Attachment #8528654 - Flags: review?(gavin.sharp) → review+
Comment on attachment 8528653 [details] [diff] [review]
be.diff

>diff --git a/browser/searchplugins/yandex.by.xml b/browser/searchplugins/yandex.by.xml

>-<SearchForm>http://www.yandex.by/</SearchForm>
>-</SearchPlugin>
>+<SearchForm>https://www.yandex.by/</SearchForm>
>+</SearchPlugin>
>\ No newline at end of file

Re-add newline.

>diff --git a/mobile/searchplugins/yandex.by.xml b/mobile/searchplugins/yandex.by.xml

> <Url type="application/x-suggestions+json" method="GET" template="http://suggest.yandex.by/suggest-ff.cgi">

No https here?

>-</SearchPlugin>
>+</SearchPlugin>
>\ No newline at end of file

Re-add newline.
Attachment #8528653 - Flags: review?(gavin.sharp) → review+
flod, can you cross-land these in repos down to central?
Flags: needinfo?(francesco.lodolo)
Side note: Belarusian will have all the extra images from Fx35, since bug 1060273 was fixed on aurora and central during this cycle.
Thanks for the help, marking this FIXED as it's landed everywhere.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.