1105042 - Users can load shelves that do not belong to the active region/carrier

Status: RESOLVED FIXED

(Marketplace Graveyard :: Curation Tools, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load the op shelf collection for DT/poland (https://marketplace.allizom.org/operators/shelves/edit/pka-operatora)
2. Change the region/carrier combo to telefonica/br

expected behavior:
* User can change the region/carrier combo only from  https://marketplace.allizom.org/operators/shelves

* region/carrier combo is shown on the details page but is not editable.

actual behavior:
When user changes the region/carrier combo from the checkbox, we still show the form details for the shelf created for the previous region/carrier combo which is confusing.

See attached screenshot

Comment 1

[Chuck Harmston [:chuck]]

Hmmm.

I think the actual issue here is that users can, if they know the slug, load existing shelves that do not belong to the active region/carrier. You should be able to change the pair on the create form, and you also should also be able to on other (not-yet existing) tools.

Feel free to disagree!

Comment 2

[Chuck Harmston [:chuck]]

https://github.com/mozilla/marketplace-operator-dashboard/commit/dce7cf06e3c4eb61422581192093fb2d9f5df3e7