If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

--disable-sandbox builds warn or error out with "dom/media/gmp/GMPLoader.cpp:68:19: error: private field 'mSandboxStarter' is not used [-Werror,-Wunused-private-field]"

RESOLVED FIXED in mozilla37

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla37
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Recently-introduced build warning (treated as error):
{
dom/media/gmp/GMPLoader.cpp:68:19: error: private field 'mSandboxStarter' is not used [-Werror,-Wunused-private-field]
}


I'm using using clang 3.5 and these lines in my mozconfig:

ac_add_options --enable-warnings-as-errors
ac_add_options --disable-sandbox
cpearce knows this code better than I do, but I think we might be able to remove the ifdef on line 166 — if MOZ_SANDBOX and/or MOZ_GMP_SANDBOX is undefined, the sandbox starter should be nullptr.
Flags: needinfo?(cpearce)
(In reply to Jed Davis [:jld] from comment #1)
> cpearce knows this code better than I do, but I think we might be able to
> remove the ifdef on line 166 — if MOZ_SANDBOX and/or MOZ_GMP_SANDBOX is
> undefined, the sandbox starter should be nullptr.

Yes, I think this would work.
Flags: needinfo?(cpearce)
(Assignee)

Updated

3 years ago
Summary: dom/media/gmp/GMPLoader.cpp:68:19: error: private field 'mSandboxStarter' is not used [-Werror,-Wunused-private-field] → --disable-sandbox builds warn or error out with "dom/media/gmp/GMPLoader.cpp:68:19: error: private field 'mSandboxStarter' is not used [-Werror,-Wunused-private-field]"
(Assignee)

Comment 3

3 years ago
Created attachment 8536970 [details] [diff] [review]
fix v1

This patch removes the #ifdef discussed above.

I can confirm that this removes the build warning & lets me compile successfully with --disable-sandbox and --enable-warnings-as-errors and clang 3.5.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8536970 - Flags: review?(cpearce)
Attachment #8536970 - Flags: review?(cpearce) → review+
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/001e0c8c26b4
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/001e0c8c26b4
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.