1105065 - --disable-sandbox builds warn or error out with "dom/media/gmp/GMPLoader.cpp:68:19: error: private field 'mSandboxStarter' is not used [-Werror,-Wunused-private-field]"

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Daniel Holbert [:dholbert]]

Recently-introduced build warning (treated as error):
{
dom/media/gmp/GMPLoader.cpp:68:19: error: private field 'mSandboxStarter' is not used [-Werror,-Wunused-private-field]
}


I'm using using clang 3.5 and these lines in my mozconfig:

ac_add_options --enable-warnings-as-errors
ac_add_options --disable-sandbox

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

cpearce knows this code better than I do, but I think we might be able to remove the ifdef on line 166 — if MOZ_SANDBOX and/or MOZ_GMP_SANDBOX is undefined, the sandbox starter should be nullptr.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Jed Davis [:jld] from comment #1)
> cpearce knows this code better than I do, but I think we might be able to
> remove the ifdef on line 166 — if MOZ_SANDBOX and/or MOZ_GMP_SANDBOX is
> undefined, the sandbox starter should be nullptr.

Yes, I think this would work.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v1

This patch removes the #ifdef discussed above.

I can confirm that this removes the build warning & lets me compile successfully with --disable-sandbox and --enable-warnings-as-errors and clang 3.5.

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/001e0c8c26b4

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/001e0c8c26b4