QuotaManager::GetInfoFromPrincipal can dereference a nullptr

NEW
Unassigned

Status

()

P5
normal
4 years ago
7 months ago

People

(Reporter: bkelly, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

At the end of QuotaManager::GetInforFromPrincipal there is this code:

  if (aGroup && aPersistenceType == PERSISTENCE_TYPE_PERSISTENT) {
    *aGroup = *aOrigin;
  }

However, the API suggests that you can optionally pass in the aOrigin pointer only if you want an origin.  If nullptr is passed for origin then this will deref null with *aOrigin.

http://dxr.mozilla.org/mozilla-central/source/dom/quota/QuotaManager.cpp?from=QuotaManager.cpp#2551
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.