Closed
Bug 1105082
Opened 9 years ago
Closed 9 years ago
Incorrect error sent when attempting to navigate in chrome scope
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(1 file, 1 obsolete file)
In bug 1093707, I took a mis-guided example from surrounding code and sent an error with a non-existent function. That patch still prevents the browser from being locked up, but results in a confusing error message.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8528712 -
Flags: review?(ato)
Assignee | ||
Comment 2•9 years ago
|
||
/r/1033 - Bug 1105082 - Send the correct error when attempting to navigate with marionette in chrome scope.;r=ato Pull down this commit: hg pull review -r 32e0c6429ecfc92771b9fac0f6ef4140beb555e7
Comment 3•9 years ago
|
||
https://reviewboard.mozilla.org/r/1031/#review577 ::: testing/marionette/client/marionette/tests/unit/test_navigation.py (Diff revision 1) > - self.assertRaises(MarionetteException, self.marionette.navigate, "about:blank") > + with self.assertRaises(MarionetteException) as e: > + self.marionette.navigate("about:blank") > + self.assertEqual(e.exception.msg, "Cannot navigate in chrome context") Can use assertRaisesRegexp for this
Assignee | ||
Comment 4•9 years ago
|
||
/r/1033 - Bug 1105082 - Send the correct error when attempting to navigate with marionette in chrome scope.;r=ato Pull down this commit: hg pull review -r 10f04d4b32ded1043ca72d88dab38436dd294179
Assignee | ||
Comment 5•9 years ago
|
||
/r/1033 - Bug 1105082 - Send the correct error when attempting to navigate with marionette in chrome scope.;r=ato Pull down this commit: hg pull review -r 2491775cbd686590c6e837cc13285c940634692b
Updated•9 years ago
|
Attachment #8528712 -
Flags: review?(ato) → review+
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8987ca07b80e
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8987ca07b80e
Assignee: nobody → cmanchester
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Updated•9 years ago
|
Target Milestone: mozilla37 → mozilla36
Assignee | ||
Comment 9•9 years ago
|
||
Attachment #8528712 -
Attachment is obsolete: true
Attachment #8618726 -
Flags: review+
Assignee | ||
Comment 10•9 years ago
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•