1105105 - [RTL] [FTE] Flip 'refresh' to left on Wifi/Networks screen

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P3)

Description

[Sam Foster [:sfoster] (he/him)]

On the Networks screen, in an RTL language, the 'Refresh' button should appear on the left of the heading, not the right.

Comment 1

[Fernando Campo (:fcampo)]

I think it's a regression, in 2.0 it appears on the left

Comment 2

[Fernando Campo (:fcampo)]

Attachment: v2.0

Comment 3

[Fernando Campo (:fcampo)]

seems like this is the culprit - https://github.com/mozilla-b2g/gaia/commit/9008d3764ec8ba33d385f666d58decd51e253e6d

For the general OS, the buttons on headers should remain on the same position (menu, back), so it seems that FTE's Network screen is an exception to the rule.

Comment 4

[Dylan Oliver [:doliver]]

RTL triage: P3 -- this bug is not prioritized for inclusion in the 2.2 release.

Comment 5

[Sam Foster [:sfoster] (he/him)]

The refresh is a part of the gaia-header, that component explicitly makes buttons not flip with document direction. Is this an exception to that rule Stephanie, or good as-is? 

Hema, ni you to get this RTL/shared web-component bug on your radar

Comment 6

[Stephany Wilkes]

There should be no exception to the header rule for 2.2. This is a bug. Thank you, Sam!

Comment 7

[Sam Foster [:sfoster] (he/him)]

(In reply to Stephany Wilkes from comment #6)
> There should be no exception to the header rule for 2.2. This is a bug.
> Thank you, Sam!

Sorry, I need to clarify. I think you are saying this is *not* a bug. Currently, 'refresh' appears to the right of the heading in both LTR and RTL. If that's the rule and there are no exceptions, I'll just resolve/invalid this bug

Comment 8

[Sam Foster [:sfoster] (he/him)]

Attachment: ltr-wifi-refresh.png

A picture being worth 1000 words, lets do it this way. Is 'refresh' in the header for the RTL version (on the right in the attached image) in the correct place here?

Comment 9

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15453/

Comment 10

[Stephany Wilkes]

That's correct, Sam. The screenshot is what I'd expect to see, and follows the bidi pattern as stated. Thanks!

Comment 11

[Sam Foster [:sfoster] (he/him)]

(In reply to Stephany Wilkes from comment #10)
> That's correct, Sam. The screenshot is what I'd expect to see, and follows
> the bidi pattern as stated. Thanks!

Ok, so the bug is invalid, there's no work to do here. 

Lancy, the moztrap case is incorrect. It states " the refresh icon should be left-aligned and read right to left. " .. that should be: " the refresh icon should be right-aligned and read right to left."

Comment 12

[Lancy(Leave from Mozilla)]

Ignore comment 9.
The bug ID tag has been removed from the TC.