Closed Bug 1105117 Opened 5 years ago Closed 5 years ago

B2G RIL: reduce the times updateRILNetworkInterface() is called

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.2 S1 (5dec)

People

(Reporter: jessica, Assigned: jessica)

Details

Attachments

(1 file)

Currently, updateRILNetworkInterface() is called on every 'networkinfochanged' [1], I think it should only be called when there is 'dataRegistrationState' in it. This will avoid RILNetworkInterface's connect() being called repeatedly.

[1] http://hg.mozilla.org/mozilla-central/file/ced1402861b8/dom/system/gonk/RadioInterfaceLayer.js#l1939
Attached patch patch, v1.Splinter Review
Comment on attachment 8528782 [details] [diff] [review]
patch, v1.

Edgar, may I have your review on this? Thanks.
Attachment #8528782 - Flags: review?(echen)
Comment on attachment 8528782 [details] [diff] [review]
patch, v1.

Review of attachment 8528782 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you.
Attachment #8528782 - Flags: review?(echen) → review+
try looks good!

https://tbpl.mozilla.org/?tree=Try&rev=e66e1db9b5cd
(Mn is perma fail right now)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a5eaa2d64353
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S1 (5dec)
You need to log in before you can comment on or make changes to this bug.