Closed
Bug 1105208
Opened 9 years ago
Closed 9 years ago
regression: (null) title for Bookmarks Toolbar, Bookmarks Menu, Unsorted Bookmarks
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
People
(Reporter: asaf, Assigned: asaf)
References
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
4.41 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
Ugh. QueryRowToResult must know that the shortcut-title is void. Patch attached. Test coming later today.
Attachment #8528982 -
Flags: review?(mak77)
Comment 1•9 years ago
|
||
Comment on attachment 8528982 [details] [diff] [review] patch (no test yet) Review of attachment 8528982 [details] [diff] [review]: ----------------------------------------------------------------- yeah, we need a test. ::: toolkit/components/places/nsNavHistory.cpp @@ +3904,5 @@ > } > > if (IsQueryURI(url)) { > // Special case "place:" URIs: turn them into containers. > nsRefPtr<nsNavHistoryResultNode> resultNode; move close to the first usage please, as it was before @@ +3927,5 @@ > + if (itemId != -1) { > + rv = aRow->GetUTF8String(nsNavBookmarks::kGetChildrenIndex_Guid, > + resultNode->mBookmarkGuid); > + NS_ENSURE_SUCCESS(rv, rv); > + } could we move this just after QueryRowToResult? doesn't look like there's a good reason to nest these 2 ifs.
Attachment #8528982 -
Flags: review?(mak77)
Comment 3•9 years ago
|
||
Mano, we need to fix this before end of the week (next week we merge to Aurora)
Flags: needinfo?(mano)
Assignee | ||
Comment 4•9 years ago
|
||
Flags: needinfo?(mano)
Attachment #8529894 -
Flags: review?(mak77)
Assignee | ||
Updated•9 years ago
|
Attachment #8528982 -
Attachment is obsolete: true
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8529894 -
Attachment is obsolete: true
Attachment #8529894 -
Flags: review?(mak77)
Attachment #8529921 -
Flags: review?(mak77)
Updated•9 years ago
|
Attachment #8529921 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/601b38d36da8
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/601b38d36da8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Updated•9 years ago
|
Target Milestone: mozilla37 → mozilla36
Updated•9 years ago
|
Flags: qe-verify?
Flags: firefox-backlog+
Updated•9 years ago
|
Flags: qe-verify? → qe-verify+
Updated•9 years ago
|
QA Contact: andrei.vaida
Comment 9•9 years ago
|
||
Reproduced the bug on an older nightly from 2014-11.26. This is now verified fixed on Aurora 36.0a2 (2014-12-01) and Nightly 37.0a1 (2014-12-02), using Windows 7 64-bit, Ubuntu 12.04 LTS 32-bit and Mac OS X 10.9.5.
Comment 10•9 years ago
|
||
Fixed on nightly. 37.0a1 (2014-12-02)
You need to log in
before you can comment on or make changes to this bug.
Description
•