1105238 - about:home layout is broken in RTL mode

Status: VERIFIED FIXED

(Snippets :: Campaign, task)

Description

[Alice0775 White]

Attachment: screenshot

Steps To Reproduce:
1. Install he locale build
2. Open about:home

Actual Results:
Video container is shifted to the right

Expected Results:
Video container should be placed in center

Comment 1

[Osmose [:osmose, :mkelly]]

Thanks for the report!

I've updated the snippet code on prod and the video looked centered properly in my local copy of Arabic Firefox.

https://github.com/mozilla/snippets/commit/7e1340d91fa91ed2e052daeec1112f9e60e4ec57

Alice: Can you force-refresh your snippets using the instructions at https://wiki.mozilla.org/Websites/Snippets/about:home_101#Manually_Forcing_a_Snippet_Refresh and verify if the updated snippet code looks correct?

Comment 2

[Alice0775 White]

Attachment: screenshot

No video.
and Fox position is too far to the left

Comment 3

[Osmose [:osmose, :mkelly]]

(In reply to Alice0775 White from comment #2)
> Created attachment 8529212 [details]
> screenshot
> 
> No video.
> and Fox position is too far to the left

Ah, that's a different snippet than the video one. Still broken, though. I'll see about fixing it as well.

Comment 4

[Osmose [:osmose, :mkelly]]

Updated the template for that snippet to work in ltr as well, tested on Firefox 33.1.1 in Hebrew.

Alice: After another force refresh, are things working again?

Comment 5

[Alice0775 White]

Confirmed, The problem is fixed.

Comment 6

[Osmose [:osmose, :mkelly]]

Cool, thanks!

Verified as per comment 5.