Closed Bug 1105295 Opened 5 years ago Closed 5 years ago

Stop using scrollinfo layers when event regions are enabled

Categories

(Core :: Panning and Zooming, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

The code in APZCTreeManager::PrepareAPZCForLayers still runs on scrollinfo layers even when the event-regions pref is turned on. This provides no actual value now that bug 1082594 is fixed, because the scrollinfo layer has no event regions. Additionally this might hide bugs in other parts of the code because the scrollinfo layer will trigger the creation of an APZC and prevent proper exercising of the DisplayportSetListener codepath in TabChild.cpp.

Given the long-term plan to take out scrollinfo layers entirely, we should stop using them when event-regions are enabled. I've been testing with this locally and everything seems to work well on B2G.
Attached patch PatchSplinter Review
Need to run gtests on this locally first.
Comment on attachment 8529093 [details] [diff] [review]
Patch

Gtests still pass
Attachment #8529093 - Flags: review?(botond)
Attachment #8529093 - Flags: review?(botond) → review+
https://hg.mozilla.org/mozilla-central/rev/1ea747d4f6c6
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.