Closed
Bug 1105295
Opened 9 years ago
Closed 9 years ago
Stop using scrollinfo layers when event regions are enabled
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
1.16 KB,
patch
|
botond
:
review+
|
Details | Diff | Splinter Review |
The code in APZCTreeManager::PrepareAPZCForLayers still runs on scrollinfo layers even when the event-regions pref is turned on. This provides no actual value now that bug 1082594 is fixed, because the scrollinfo layer has no event regions. Additionally this might hide bugs in other parts of the code because the scrollinfo layer will trigger the creation of an APZC and prevent proper exercising of the DisplayportSetListener codepath in TabChild.cpp. Given the long-term plan to take out scrollinfo layers entirely, we should stop using them when event-regions are enabled. I've been testing with this locally and everything seems to work well on B2G.
Assignee | ||
Comment 1•9 years ago
|
||
Need to run gtests on this locally first.
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8529093 [details] [diff] [review] Patch Gtests still pass
Attachment #8529093 -
Flags: review?(botond)
Updated•9 years ago
|
Attachment #8529093 -
Flags: review?(botond) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/1ea747d4f6c6
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1ea747d4f6c6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•