Fix to use indexed encoding for cookies more than 20 bytes

RESOLVED FIXED in mozilla36

Status

()

Core
Networking: HTTP
--
minor
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Shigeki Ohtsu, Assigned: Shigeki Ohtsu)

Tracking

Trunk
mozilla36
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [spdy])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8529098 [details] [diff] [review]
mypatch.diff

I found that cookie headers are always encoded with LiteralHeaderNeverIndexed regardless of their size.
The comment in HTTP2Compression.cpp intends that they should be encoded with indexing when their size is more than 20 bytes.
There is a written mistake of a variable name in checking a cookie size and this patch corrects it.
thanks..
Assignee: nobody → ohtsu
Whiteboard: [spdy]
Attachment #8529098 - Flags: review+
Thank you for identifying and crafting the fix. It has been pushed to gecko 36 which is currently the first branch we announce non-draft h2 support for. If we move the h2 announcement to an earlier branch I'll consider moving this too.

I changed a test so that it at least tickles the cookie indexing code.
(Assignee)

Comment 4

3 years ago
Thanks for your reviewing and adding the test. I tested it with my iij-http2 server but missed to find where unit tests exist in the Firefox repository. I will take a look at them next time.
https://hg.mozilla.org/mozilla-central/rev/c97ed39af3f7
Status: UNCONFIRMED → RESOLVED
Last Resolved: 3 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.