1105312 - Fix Adobe Reader Icon

Status: RESOLVED FIXED

(Plugin Check Graveyard :: UI, defect)

Description

[Schalk Neethling [:espressive]]

A small bug that slipped through on the last PR. Update check-plugins.js to use RegEx for Adobe Reader/Acrobat icon.

Comment 1

[Schalk Neethling [:espressive]]

PR opened https://github.com/mozilla/bedrock/pull/2547

Comment 2

[DJ-Leith]

The change, see next, seems to have happened.
However I am a little surprised.

https://bug1101613.bugzilla.mozilla.org/attachment.cgi?id=8528636
  above is a screenshot, taken on 2014-11-25,
  showing Adobe Reader: has lost the 'red Reader logo'. 
  (quoted from bug 1101613 comment # 3)

In Bug 1101613 comment # 4
Schalk Neethling is quoting DJ-Leith from 1101613 comment # 3
> > For a Recent (2014-10-21) Plugincheck showing "Google Earth Plugin"
> > see
> > https://bug1084537.bugzilla.mozilla.org/attachment.cgi?id=8509897
> > 
> > Minor point, compare the two screenshots and you will see that
> >   "Adobe Reader" has lost the 'red Reader logo'
> 
> This is a small bug that I actually have fixed but did not merge into
> Bedrock. Will open a PR to fix that.

Using the new Release, Fx 34.0, about 6 hours ago (Tue Dec 2 2014 07:02:02 PST)
I noticed that the Icon for Adobe Reader is now showing
like it used to, similar to
https://bug1084537.bugzilla.mozilla.org/attachment.cgi?id=8509897

I am happy that the Plugincheck Website is showing the
'Adobe logo for Reader' again.

However, I am surprised that it happened BEFORE the '[github robot] push record'.

I was expecting a comment like this:

> [github robot]
> Commits pushed to master at https://github.com/mozilla/bedrock

DJ-Leith

Comment 3

[DJ-Leith]

The Bedrock change has not happened.

I now think I have understood the situation described in comment # 2 a bit better.
I did see a 'red logo' but I did not double check WHY I saw this.

I have done more testing today and I have noticed something that I missed.

A. See
    https://bug1084537.bugzilla.mozilla.org/attachment.cgi?id=8509897
    Screenshot taken on 2014-10-21 showing "Adobe Acrobat"
      (which is in the "Product name" field in plugin metadata, from
      the file "nppdf32.dll", - THE plugin).
    Note also the "... Netscape 11.0.9", in the second line describing
    the "Adobe Acrobat".  This is also, I speculate, from the metadata.

B. See
    https://bug1101613.bugzilla.mozilla.org/attachment.cgi?id=8528636
    Screenshot taken on 2014-11-25 showing "Adobe Reader",
       which is from the 'JSON List' data.
       The obvious thing you will see is the logo is generic
       (not Adobe's logo).
    The more subtle point is that there is there is NO 'version'
    in the in the second line describing the "Adobe Reader".
    Instead, there is JUST "Adobe PDF Plug-In For Firefox and Netscape".
    Both "Adobe Reader" and "Adobe PDF Plug-In For Firefox and Netscape"
    come from the 'JSON List' (not the metadata).
       
    See
    https://bug1020133.bugzilla.mozilla.org/attachment.cgi?id=8487601
    In this example, from 2014-09-10, there are 5,428 lines in the 'JSON List'.

> 1618      'adobe-reader': {
> 1619        'display_name': 'Adobe Reader',
> 1620        'description': 'Adobe PDF Plug-In For Firefox and Netscape',

So the 'Plugincheck Website' is showing data from the 'JSON List' in this case.


Testing today, 2014-12-04, using Fx 34 (current Release) with:
* UA spoof to Fx 31, I get similar to A ("Adobe Acrobat" with 'red logo')
* UA spoof to Fx 36, I get similar to B ("Adobe Reader", no 'red logo',
    and no "... Netscape 11.0.9")

So, just awaiting for the Bedrock bug to complete.

DJ-Leith

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/1bc964bc466860bc6fd1775e1b66adc3ac6ce5c8
Fix Bug 1105312, fixes adobe reader icon on plugincheck page

https://github.com/mozilla/bedrock/commit/b4353421135db5bc915988a388244b9d49d00fed
Merge pull request #2547 from ossreleasefeed/bug1105312-fix-adobe-reader-icon-plugincheck

Fix Bug 1105312, fixes adobe reader icon on plugincheck page

Comment 5

[DJ-Leith]

This has NOT done 'what Schalk Neethling and I were expecting':
the icon has NOT changed.
The 'wrong icon' is a 'trivial symptom' of a more important issue.

Testing again today, 2014-12-08, using Fx 34 (current Release) with:
* UA spoof to Fx 31, I get similar to A ("Adobe Acrobat" with 'red logo')
* UA spoof to Fx 36, I get similar to B ("Adobe Reader", no 'red logo',
    and no "... Netscape 11.0.9")

In addition,
testing with Fx 36.0a2 (2014-12-08)
I get similar to B ("Adobe Reader", no 'red logo', and no "... Netscape 11.0.9").

In order to get 'any report at all', in all 3 tests, I had to allow enumeration of plugins
("plugins.enumerable_names" set to "*").

Between May 2014 and 2014-11-24, using Aurora, I got 'a result' without ANY
plugin enumeration ("plugins.enumerable_names" set to "" empty string).

So, my interpretation of
Result A 'red Adobe logo'
vs
Result B 'blue generic logo' 

Is,
A shows that the data used for the evaluation of the Plugins is collected from,
or "fetechd" from, the Plugincheck Databases using the 'pre May 2014 method Plugincheck'.

B shows that data contained in the 'JSON List' has been used at the 'Plugincheck Website'.


However, unlike all tests that I have done - using Aurora - between May 2014 and 2014-11-24,
where both bug 1020133 comment # 85 and  bug 1101613 comment # 2, said that
changes had arrived at production, I have had to enable enumeration of ALL plugins
("plugins.enumerable_names" set to "*").

So while this bug is JUST about the logo, the bigger issue is that the changes
on 2014-11-24 are NOT 'limited to the missing red Adobe logo', they are wider.

I will continue to discuss this in bug 1101613 "PluginCheck Database Clearance".

DJ-Leith

Comment 6

[Alex Gibson [:agibson]]

Please give us a bit of time to push this change to production before testing. It has been merged into master, but not quite yet in production.

Comment 7

[DJ-Leith]

(In reply to Alex Gibson [:agibson] from comment #6) 
> Please give us a bit of time to push this change to production before testing.
> It has been merged into master, but not quite yet in production.

Alex,
thanks for telling me. I misunderstood the "Commits pushed to master ..."
> [github robot] 2014-12-08 03:24:59 PST 
i.e. comment # 4.

I have now found:

http://bedrock.readthedocs.org/en/latest/php.html#workflow
> Workflow
> 
> If you are working on a bug, please follow these steps:
> 
> 1. Commit your work to trunk
<snip>
> We release a batch of resolved bugs every Tuesday. Other bugs can go
> out between releases, but by default resolved bugs tagged with the current
> milestone will go out the next Tuesday.

So I now think that this bug was 'one of the batch for Tuesday'. 

Testing today, 2014-12-04 at 14:00 PST, using Fx 34 (current Release) with:
* UA spoof to Fx 31, I get similar to A ("Adobe Acrobat" with 'red logo')
* UA spoof to Fx 36, I get similar to B ("Adobe Reader", BUT *with* 'red logo',
    and no "... Netscape 11.0.9")

Good News! The change has now happened, the 'logo is OK'.

Schalk,
thanks very much for the "general status update" in bug 956905 (and other bugs).

DJ-Leith