If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove app_api_all waffle flag

RESOLVED FIXED

Status

Socorro
Webapp
RESOLVED FIXED
3 years ago
10 months ago

People

(Reporter: peterbe, Assigned: peterbe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We're currently protecting all of the public web api with the app_api_all waffle flag. 

That means we have to rely on a DB call before it can do anything. And this can error out like it has done 3,300 times on stage https://errormill.mozilla.org/webtools/socorro-stage/group/169483/

Removing it, we can potentially speed up the public API a lot.
(Assignee)

Comment 1

3 years ago
Do you know any good reason to keep it? 

The way I see it, waffle flags are meant for "soft roll-out" of new features. They are cumbersome for developers who don't know the management commands by heart and the waffle machine doesn't use the caching framework.
Flags: needinfo?(chris.lonnen)
Flags: needinfo?(adrian)

Comment 2

3 years ago
I don't know of a good reason to keep it.

We may want to look into a waffle replacement in the future that's a little easier to work with.
Flags: needinfo?(chris.lonnen)
waffle switches are here to make sure we have an easy way to switch off a risky feature. Once we know that feature is safe, there is no point on keeping the switch around. So yes, let's remove the API waffle switch! :)

As a side-note, maybe we should file an end-of-life bug for each waffle switch that we introduce in the code? With some kind of reminder that we need to do it after ~2/3 months?
Flags: needinfo?(adrian)
(Assignee)

Updated

10 months ago
Assignee: nobody → peterbe
(Assignee)

Comment 4

10 months ago
Created attachment 8811010 [details] [review]
Link to Github pull-request: https://github.com/mozilla/socorro/pull/3589

Comment 5

10 months ago
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/9120598a186af10076a0607c573d4f0ba65242b0
fixes bug 1105349 - Remove app_api_all waffle flag (#3589)
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.