1105351 - [Usage][RTL] Make First Time Experience View RTL compatible

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Oleg Zasypkin [:azasypkin]]

In general FTE view looks good in RTL, but it still needs some adjustments:

* Location of radio buttons;
* Some text alignment/margins/paddings;
* Compound currency symbol (eg. R$).

Comment 1

[Oleg Zasypkin [:azasypkin]]

Attachment: GitHub pull request URL

Comment 2

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8529155 [details] [review]
GitHub pull request URL

Hey Marina,

Could you please take a look at this patch? I've left some comments at GitHub.

Thanks!

Comment 3

[Marina Rodríguez [:mai]]

Comment on attachment 8529155 [details] [review]
GitHub pull request URL

Arnau, 
Would you mind taking a look to the layout.css changes?

Regards,
Mai

Comment 4

[Marina Rodríguez [:mai]]

Comment on attachment 8529155 [details] [review]
GitHub pull request URL

LGTM,
thanks oleg.
Wait for Arnau's review. ;)

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: layout-ltr.png

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: layout-rtl.png

Comment 7

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Oleg,
I guess the first two checkboxes in https://bug1105351.bugzilla.mozilla.org/attachment.cgi?id=8530839 should be right aligned.
I have also attached ltr screeshot here: https://bug1105351.bugzilla.mozilla.org/attachment.cgi?id=8530838

The use cases the example is showing in ltr, could be when you ask the user to accept terms and conditions (checkbox left aligned) and where you show a list of options (right aligned).

Could you please fix that?
Thanks!

clearing review, please ask again when fixed :)

Comment 8

[Oleg Zasypkin [:azasypkin]]

(In reply to Arnau March  [:arnau] from comment #7)
> Oleg,
> I guess the first two checkboxes in
> https://bug1105351.bugzilla.mozilla.org/attachment.cgi?id=8530839 should be
> right aligned.
> I have also attached ltr screeshot here:
> https://bug1105351.bugzilla.mozilla.org/attachment.cgi?id=8530838
> 
> The use cases the example is showing in ltr, could be when you ask the user
> to accept terms and conditions (checkbox left aligned) and where you show a
> list of options (right aligned).
> 
> Could you please fix that?
> Thanks!
> 
> clearing review, please ask again when fixed :)

Hey Arnau,

Could you please point to any gaia app (or at least to this nice app that you used to make screenshots) that uses it to test the fix? I wasn't able to find anything broken that looks like this :) .

Thanks!

Comment 9

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

(In reply to Oleg Zasypkin [:azasypkin] from comment #8)
> (In reply to Arnau March  [:arnau] from comment #7)
> > Oleg,
> > I guess the first two checkboxes in
> > https://bug1105351.bugzilla.mozilla.org/attachment.cgi?id=8530839 should be
> > right aligned.
> > I have also attached ltr screeshot here:
> > https://bug1105351.bugzilla.mozilla.org/attachment.cgi?id=8530838
> > 
> > The use cases the example is showing in ltr, could be when you ask the user
> > to accept terms and conditions (checkbox left aligned) and where you show a
> > list of options (right aligned).
> > 
> > Could you please fix that?
> > Thanks!
> > 
> > clearing review, please ask again when fixed :)
> 
> Hey Arnau,
> 
> Could you please point to any gaia app (or at least to this nice app that
> you used to make screenshots) that uses it to test the fix? I wasn't able to
> find anything broken that looks like this :) .
> 
I have used the example in shared/style/layout/index.html :)

> Thanks!

Comment 10

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8529155 [details] [review]
GitHub pull request URL

Okay, done + some other small changes to make "shared/style/layout/index.html" look better in RTL :)

Arnau, could you please take a look again?

Thanks!

Comment 11

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8529155 [details] [review]
GitHub pull request URL

the BB part looks great.
Thanks Oleg ;)

Comment 12

[Oleg Zasypkin [:azasypkin]]

Marina & Arnau, thanks for review!

Master: https://github.com/mozilla-b2g/gaia/commit/8749f73d244ebabfa5b7202713d7cf34ab8a4ffe

Comment 13

[Sue]

Attachment: verify_pass.png

This issue has been verified as pass on latest build of Flame 2.2&3.0 and Nexus 5 2.2&3.0 by STRs:
1. Insert a SIM card in device and set system language as Arabic.
2. Launch Usage for the first time.
3. Observe all views in FTE. 
**Texts and buttons in all views in FTE are shown correctly. The layouts of FTE views are correctly.
See attachment:verify_pass.png
Rate:0/3

Device: Flame 2.2 (pass)
Build ID               20150525002504
Gaia Revision          144673a413586f98b5e2c27b781c1a539611f754
Gaia Date              2015-05-25 02:01:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c4db2af40b1b
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150525.041143
Firmware Date          Mon May 25 04:11:54 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 (pass)
Build ID               20150525160205
Gaia Revision          5bcc08a732163087999251b523e3643db397412c
Gaia Date              2015-05-24 14:44:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b6623a27fa64
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150525.192755
Firmware Date          Mon May 25 19:28:07 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 2.2 (pass)
Build ID               20150525002504
Gaia Revision          144673a413586f98b5e2c27b781c1a539611f754
Gaia Date              2015-05-25 02:01:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c4db2af40b1b
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150525.041303
Firmware Date          Mon May 25 04:13:19 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 3.0 (pass)
Build ID               20150525160205
Gaia Revision          5bcc08a732163087999251b523e3643db397412c
Gaia Date              2015-05-24 14:44:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b6623a27fa64
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150525.192207
Firmware Date          Mon May 25 19:22:24 EDT 2015
Bootloader             HHZ12f