1105385 - Bookmark Keyword searches auto go to the default search engine

Status: RESOLVED WORKSFORME

(Toolkit :: Places, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:
Add a keyword search for mxr.mozilla.org using the keyword 'mxr'
In the address bar, type 'mxr foo'
Hit Enter

ER:
A search for 'foo' is performed at mxr.mozilla.org

AR:
A search at the default engine is performed for the search URL of MXR. In the Google case, it is:
https://www.google.com/search?q=%7B%22url%22%3A%22http%3A%2F%2Fmxr.mozilla.org%2Fmozilla-central%2Fsearch%3Fstring%3Dfoo%26find%3D%26findi%3D%26filter%3D%5E%5B%5E%5C0%5D*%2524%26hitlimit%3D%26tree%3Dmozilla-central%22%2C%22input%22%3A%22mxr+foo%22%7D&ie=utf-8&oe=utf-8&aq=t&rls=org.mozilla:en-US:unofficial&client=firefox-nightly&channel=fflb

Comment 1

[Marco Bonardo [:mak]]

Are you sure this is due to bug 1067903 and not due to bug 1083469?

Is it still broken if you restart the browser?

Comment 3

[Marco Bonardo [:mak]]

just to be sure, here you are referring to a bookmark keyword, right? not a search engine keyword (set through the search engines management panel)

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Yes, a bookmark keyword. Sorry for the ambiguity.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

With 2014-11-27 Nightly on Windows 7 I can no longer reproduce this.

Comment 6

[Marco Bonardo [:mak]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> With 2014-11-27 Nightly on Windows 7 I can no longer reproduce this.

we disabled unified complete, so that doesn't matter. We still need to fix this.

Comment 8

[Mark Hammond [:markh] [:mhammond]]

I can't reproduce this in nightly with unified autocomplete enabled.  I created a bookmark with keyword "bug". When I enter "bug" in the URL bar, the popup shows "bugzilla.mozilla.org: " with a search icon. When I enter more characters (eg, "bug foo") the popup reflects this (ie "bugzilla.mozilla.org: foo" still with a search icon. Pressing enter executes the search as expected.

Comment 9

[Mark Hammond [:markh] [:mhammond]]

Jaws, can you please try and repro this again?

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

I can't reproduce this bug on Nightly 2015-05-04. It's been working for me for some time now. Thanks for the ping.