1105393 - Remove deprecated for-each-in loops from mochitest/server.js

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: 1083467_fix-mochitest-server.patch

Bug 1083467 will log console warnings for JavaScript 1.6's deprecated for-each-in loops. This patch will replaces some for-each-in loops in the mochitest harness itself with for-of loops to reduce test warning spam.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8529170 [details] [diff] [review]
1083467_fix-mochitest-server.patch

Review of attachment 8529170 [details] [diff] [review]:
-----------------------------------------------------------------

my only concern here is we run this from xpcshell and peg a certain version of javascript with -v 170.  I would like to ensure that we successfully test this on mochitest and reftest (remote).  here are the two cases I see of invoking server.js:
http://dxr.mozilla.org/mozilla-central/source/layout/tools/reftest/remotereftest.py#208
http://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py#328

::: testing/mochitest/server.js
@@ +548,5 @@
>  function jsonArrayOfTestFiles(links)
>  {
>    var testFiles = [];
>    arrayOfTestFiles(links, testFiles);
> +  testFiles = [for (file of testfiles) '"' + file['url'] + '"'];

I know this is a direct conversion of what was in place before, but shouldn't we use a let to define file?

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: fix-mochitest-server-v2.patch

Remove deprecated for-each-in loops from mochitest/server.js, but this time don't use any ES6/ES7 language features that are not available in the Android emulators' ancient (2012) hostutils.zip xpcshell.

(mostly) green Try test:
https://tbpl.mozilla.org/?tree=Try&rev=7814367ffb08

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8539923 [details] [diff] [review]
fix-mochitest-server-v2.patch

Review of attachment 8539923 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

Comment 4

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/19423317b16e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/19423317b16e