110543 - Replace S/MIME alerts with chrome instead.

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect)

Description

[David P. Drinan]

When reading signed and/or encrypted mail, an alert popup is displayed. This 
information should be reflected in the chrome instead.

Comment 1

[Scott MacGregor]

Hey Kai, I actually wrote a lot of code to do this over the weekend and just
noticed this bug. I just need to scrounge up some icons to plug in and it should
be good to go. Do you mind if I take this from you? I'll post some diffs
tomorrow so you can see what I did. 

Comment 2

[Stephane Saux]

Scott: The current design is http://www.mozilla.org/mailnews/specs/security/
Section E: Reading Mail.  Kai can help you in any way you want.

Comment 3

[Tracy Walker [:tracy]]

*** Bug 110487 has been marked as a duplicate of this bug. ***

Comment 4

[Scott MacGregor]

thanks Stephane, that's the spec I've been using already. I was giving some
feedback to Jennifer about it a couple weeks ago. 

Comment 5

[Scott MacGregor]

Attachment: adds UI in the form of an overlay for message display

This patch implements the UI for message display with smime support. I've added
a new overlay: msgHdrViewSMIMEOverlay which contains the UI elements for
showing smime information in the message pane. If extentions\smime is built as
part of your build, then you'll get this new overlay when you display a
message.

Currently, we just show raw text saying:
'Signed'
and
'Encrypted'
in the exact locations the icons should be according to the spec. I need to get
some icons from the UI team to insert in place of the text. 

We may still want to take this patch "as is" pending reviews so folks don't get
the JS Alerts. But the polished product will eventually need the new icons
instead of my text strings saying "Signed" or "Encrypted".

Comment 6

[Kai Engert (:KaiE:)]

I think the patch looks good. I agree that we should check this in even without
icons, to remove the JS alerts quickly. We will need updated Linux and Mac
makefiles, though. I can provide the Linux makefile.

Comment 7

[Kai Engert (:KaiE:)]

Scott: In your makefiles, you added a check for BUILD_PSM2. At different
locations we check for BUILD_SMIME. Do we want to change that?

Comment 8

[Kai Engert (:KaiE:)]

Oops, I didn't remove the dependency. Re-adding.
No idea why bugzilla did that. Maybe because of mid air collision.

Comment 9

[Kai Engert (:KaiE:)]

Attachment: Linux makefile changes

Scott, your patch works for me on Linux.
This are the required Linux makefile changes.

Comment 10

[Scott MacGregor]

oh cool thanks for the unix patch Kaie. That's an oversight in my makefile.win
that I'm using BUILD_PSM2 instead of BUILD_SMIME. I made the change in my tree.
Nice catch. 

Comment 11

[Scott MacGregor]

Comment on attachment 58445 [details] [diff] [review]
adds UI in the form of an overlay for message display

I got an sr=sspitzer on this last night.

Comment 12

[Scott MacGregor]

Kai, do you mind reviewing the code for an r=?

Comment 13

[Kai Engert (:KaiE:)]

Comment on attachment 58445 [details] [diff] [review]
adds UI in the form of an overlay for message display

I looked over the code in more detail, and it still looks good.

I can't decide whether the QueryInterface chain from mime_stream_data to
nsIMsgSMIMEHeaderSink is correct, I'll trust you, as it works.

You seem to include fixes for some other issues that might be unrelated with
this bug. But that's fine (especially you add on optimization , where you check
for charset us-ascii.)

r=kaie

Comment 14

[Scott MacGregor]

thanks for the review kai. There were 2 other mime changes in that diff that you
noticed that I included by accident (including the ascii 'optimization'). I
won't be checking those in as part of this checkin. I didn't mean to put those
in there. Good catch.

Comment 15

[Kai Engert (:KaiE:)]

Javi, can you please carpool with Scott for the Mac project file changes?

Scott added a new file in mailnews/extensions/smime/public. If I understood you
correctly, no changes are required for new dependency in mailnews/mime/src and
the updated jar.mn files.

Let me know if I can help to land this.

Comment 16

[Scott MacGregor]

*** Bug 111995 has been marked as a duplicate of this bug. ***

Comment 17

[timeless]

msghdrviewsmimeoverlay appears to have a few bugs in the license block
1. gerv will scream bloody murder for not tri licensing.
2. the email address seems to be missing a >
3. this code isn't mozilla communicator code released in march of 1998.

Comment 18

[Scott MacGregor]

after a bump with a mac IDL project, this patch is now checked in. You'll now
see text saying "Signed" and "Encryted" instead of the JS Alerts. The text nodes
in msgHdrViewSMIMEOverlay.xul can be replaced with image icons once we
manufacture those icons. Bug 104502 tracks that dependency.

Comment 19

[Tracy Walker [:tracy]]

marking fixed per comments and not seeing this on the latest builds

Comment 20

[John Unruh]

Verified.