1105438 - Native FxA needs to side-step the sign-in button page for login

Status: RESOLVED INVALID

(Marketplace Graveyard :: Payments/Refunds, defect, P3)

Description

[Stuart Colville [:muffinresearch]]

Persona required us to do a click for the login. FxA doesn't. The web-based flow already bypasses these views for login and reset. Native FxA should too.

Once this is done these views should be removed entirely. 

Bear in mind there's parts of the existing tests that use this flow that are going to look for those pages so those will need updating too.

Looks like the reset side might have already been solved here in bug 1103103

Comment 1

[Stuart Colville [:muffinresearch]]

Note this requires the enableNativeFxA setting to be true to be seen.

Comment 2

[Stuart Colville [:muffinresearch]]

PR: https://github.com/mozilla/spartacus/pull/184

Comment 3

[Stuart Colville [:muffinresearch]]

Re-purposing this bug for login only as it will be easier to test. Will file a separate bug for reset as that's a separate issue.

LOGIN button STR:

You can repro seeing the old persona login button from in-app payments tester.

* Use FFOS 2.1
* Without being logged in to FxA 
* Open the in-app payment tester app and point it at marketplace-dev
* Click refresh JWT
* This will show the button that needs to be clicked to continue logging in.

Comment 4

[Stuart Colville [:muffinresearch]]

After testing the branch I'd setup for side-stepping the login click with Charles on -dev. I found that the indentity code that runs for NAtive FxA still requires the login to happen based on user input. As a result of that we aren't going to be able to remove this page because the request must happen on user input.

Marking as invalid and filing a new bug to update the UX of that page instead. It's worth noting that due to the login from Marketplace the only time users will hit this is for login for in-app payments and resets.