Autolander may be too aggressive when coalescing bugs

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Opening this bug to track if autolander may be too aggressive when landing to master from the integration branch. I just did a test on gaia master with three commits in parallel, and I think the last commit may have landed before it turned green.

Opening this bug to verify the issue, and at least write a test for it.
Created attachment 8529229 [details] [review]
[PullReq] KevinGrandon:bug_1105440_calm_down_autolander to KevinGrandon:master
(Assignee)

Comment 2

4 years ago
Comment on attachment 8529229 [details] [review]
[PullReq] KevinGrandon:bug_1105440_calm_down_autolander to KevinGrandon:master

Doh, turns out this was a pretty major bug and we were using the wrong sha to fast-forward master. Could either of you guys review this?
Attachment #8529229 - Flags: review?(jlal)
Attachment #8529229 - Flags: review?(garndt)

Comment 3

4 years ago
Comment on attachment 8529229 [details] [review]
[PullReq] KevinGrandon:bug_1105440_calm_down_autolander to KevinGrandon:master

Changes make sense to me.
Attachment #8529229 - Flags: review?(garndt) → review+
(Assignee)

Updated

4 years ago
Attachment #8529229 - Flags: review?(jlal)
(Assignee)

Updated

4 years ago
Keywords: checkin-needed

Updated

4 years ago
Keywords: checkin-needed

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.