Closed
Bug 1105440
Opened 10 years ago
Closed 10 years ago
Autolander may be too aggressive when coalescing bugs
Categories
(Firefox OS Graveyard :: Gaia::GithubBot, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
Attachments
(1 file)
Opening this bug to track if autolander may be too aggressive when landing to master from the integration branch. I just did a test on gaia master with three commits in parallel, and I think the last commit may have landed before it turned green. Opening this bug to verify the issue, and at least write a test for it.
|
||
Comment 1•10 years ago
|
||
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8529229 [details] [review] [PullReq] KevinGrandon:bug_1105440_calm_down_autolander to KevinGrandon:master Doh, turns out this was a pretty major bug and we were using the wrong sha to fast-forward master. Could either of you guys review this?
Attachment #8529229 -
Flags: review?(jlal)
Attachment #8529229 -
Flags: review?(garndt)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8529229 [details] [review] [PullReq] KevinGrandon:bug_1105440_calm_down_autolander to KevinGrandon:master Changes make sense to me.
Attachment #8529229 -
Flags: review?(garndt) → review+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8529229 -
Flags: review?(jlal)
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
||
Comment 4•10 years ago
|
||
Pull request has landed in master: https://github.com/KevinGrandon/autolander/commit/fdeab5d6568871153e3505bb587f52709ee9fb6a
|
|
||
Updated•10 years ago
|
Keywords: checkin-needed
|
|
||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•