1105469 - Add bookmark dialog won't allow spaces anywhere in keyword

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Matthew Flaschen]

Attachment: Screenshot dialog blocking save.png

User Agent: Mozilla/5.0 (Android; Mobile; rv:26.0) Gecko/26.0 Firefox/26.0
Build ID: 20131205073515

Steps to reproduce:

1. Click star to start adding a bookmark.
2. Put a space in the keyword field, either as part of a tag or after a comma.

An example would be a keyword field of:

open source, machine translation


Actual results:

It will not allow you to save if there are spaces anywhere  (except after a trailing comma).


Expected results:

It should allow saving.  It is good UX to allow spaces after commas (people add them due to habit, and my Galaxy S4 keyboard sometimes adds a space herw of its on accord), but it is required for tags  (I don't want to spell open source as "machinetranslation", and in other cases this would be even less readable).

This is also very inconsistent with Firefox for desktop, which allows spaces in tag fields without issue.

Comment 1

[Aaron Train [:aaronmt]]

http://dxr.mozilla.org/mozilla-central/source/mobile/android/base/EditBookmarkDialog.java?from=EditBookmarkDialog.java&case=true#128

Added in bug 856558

We treat keywords different than tags. This was discussed in bug 961033. Tagging is not yet supported (bug 775672).

Comment 2

[Aaron Train [:aaronmt]]

Taking this off unconfirmed list.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.