Closed Bug 1105490 Opened 6 years ago Closed 5 years ago

Remove old ToS generation code, once new ToS have rolled out and old links are obsolete

Categories

(Hello (Loop) :: Client, defect, P2)

defect
Points:
2

Tracking

(firefox40 fixed)

RESOLVED FIXED
mozilla39
Iteration:
40.1 - 13 Apr
Tracking Status
firefox40 --- fixed
Blocking Flags:
backlog tech-debt

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [tech-debt])

Attachments

(1 file)

Bug 1105488 is switching the ToS url away from the loop-client server.

This means we should be able to clean up our code at some stage. I suspect we need:

- File a bug on ops to make the existing ToS url a redirect (for FF 34 users)
- Remove the old generation code (not sure if we want to keep Grunt for some of the perf improvements we want to do).
backlog: --- → Fx38?
Assignee: nobody → standard8
backlog: Fx38? → tech-debt
Priority: -- → P2
Ops has asked me to make at least part of this happen as it helps with some new automation they are creating. The initial change I did to test for them wasn't too difficult, so lets just see if we can knock this off before the next release.
Iteration: --- → 40.1 - 13 Apr
Points: --- → 2
Rank: 25
Flags: qe-verify-
Flags: firefox-backlog+
OS: Mac OS X → All
Hardware: x86 → All
This is basically a backout of bug 1044411 but keeping some bits intact as they seemed good to keep.

Ted: Could you review the .hgignore parts? (the Makefile isn't part of the m-c build system atm).

Dan: Ops want this for the next loop-client release at it makes their process simpler and easier to automate. We can always add grunt back in later if we need it for the minify/concatinate stuff, but for now, lets just drop it and simplify things.
Attachment #8585397 - Flags: review?(ted)
Attachment #8585397 - Flags: review?(dmose)
Attachment #8585397 - Flags: review?(ted) → review+
Comment on attachment 8585397 [details] [diff] [review]
Remove old ToS generation code from Loop Standalone. NPOTB DONTBUILD

Review of attachment 8585397 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great; thanks for doing this.  I don't think we're going to want to go back to grunt.  The lesson I learned with this stuff is that debugging grunt is a giant pain.  We might consider gulp one day, but perhaps Make will continue to be sufficient.
Attachment #8585397 - Flags: review?(dmose) → review+
https://hg.mozilla.org/mozilla-central/rev/d7e29ec6a512
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.