1105507 - Move reviewer approve logic to celery task

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Reviewer Tools, defect, P4)

Description

[Rob Hudson [:robhudson]]

I propose we move all the logic that happens when a reviewer approves an app to a celery task. That's roughly all of this code:
https://github.com/mozilla/zamboni/blob/bbff4145/mkt/reviewers/utils.py#L206-L304

Essentially the new task would do the following:
* Update the app status and file status
* Put timestamps where necessary (reviewed datetime)
* Update any info from the updated package
* Sign the app
* Reindex the app info
* Issues reviewer incentive points
* Tell IARC about this app
* etc.

I'm creating this as a blocker for bug 936444 so a new package update doesn't trigger all the above plus require the db transaction stuff we used in reviewer tools. The app developer may have to wait a couple minutes for the task to be completed but that seems reasonable.

Comment 1

[Andrew Williamson [:eviljeff]]

I added bug 1122263 as blocker because it seemed to be nearly the same use-case as bug 936444 - i.e. auto-approving of a package leading to all the stuff mentioned in #c0 (sans IARC).  Should it be a blocker?  If not, is it a blocker on 936444 still?

Comment 2

[Rob Hudson [:robhudson]]

(In reply to Andrew Williamson [:eviljeff] from comment #1)
> I added bug 1122263 as blocker because it seemed to be nearly the same
> use-case as bug 936444 - i.e. auto-approving of a package leading to all the
> stuff mentioned in #c0 (sans IARC).  Should it be a blocker?  If not, is it
> a blocker on 936444 still?

I'm going to leave this up to mat. If he wants it to be a blocker and needs/wants help I'm happy to jump in. We talked on IRC previously and he was going to decide on this soon.

Comment 3

[Mathieu Pillard [:mat]]

It could block bug 1122277, but I'm not sure yet, I'll look into that later this week. Langpacks don't have statuses, they are active or not and that's it, so they wouldn't necessarily share a lot of code with the reviewer stuff we have for apps.