Closed Bug 1105520 Opened 7 years ago Closed 7 years ago

Open the conversation window when I create a room

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
2

Tracking

(firefox35 verified, firefox36 verified)

VERIFIED FIXED
mozilla36
Iteration:
36.3
Tracking Status
firefox35 --- verified
firefox36 --- verified
Blocking Flags:
backlog Fx35+

People

(Reporter: MattN, Unassigned)

References

Details

(Whiteboard: [needed for FTE/U])

Attachments

(1 file)

When a room is created, the conversation pane should open immediately according to the UX spec.

I'm personally kind of on the fence for this since I don't want my webcam to come on just because I created a room that I may only want to use for a meeting in a week.
backlog: Fx35? → Fx35+
Priority: -- → P1
Whiteboard: [needed for FTE/U]
Assignee: nobody → nperriault
Iteration: --- → 36.3
Points: --- → 2
Comment on attachment 8529689 [details] [diff] [review]
Open Loop room conversation window right after it's created.

Review of attachment 8529689 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/test/shared/roomStore_test.js
@@ +79,5 @@
>          copyString: function() {},
>          rooms: {
>            create: function() {},
>            getAll: function() {},
> +          open: function() {},

perhaps it's good to sinon.stub() this and check if calledOnce() in your new test?
Attachment #8529689 - Flags: review?(mdeboer) → review+
(In reply to Mike de Boer [:mikedeboer] from comment #2)
> perhaps it's good to sinon.stub() this and check if calledOnce() in your new
> test?

It's already tested in #openRoom :)
https://hg.mozilla.org/mozilla-central/rev/67e4cff50baa
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment on attachment 8529689 [details] [diff] [review]
Open Loop room conversation window right after it's created.

Approval Request Comment
[Feature/regressing bug #]: Rooms

[User impact if declined]: Confusing flow for users - you create a room, share the link, but the notification someone entered it is subtle and may be missed.  Users may assume it someone entering the room will pop a request like it did in the FF34 link-sharing UI, and they may assume it's broken.  You can still leave a room after creating it.

[Describe test coverage new/current, TBPL]: includes test

[Risks and why]: low risk - just invokes a well-traveled path to pope open a room.  After getting some experience in rooms we realized the flow was confusing.

[String/UUID change made/needed]: none
Attachment #8529689 - Flags: approval-mozilla-aurora?
Flags: qe-verify+
Comment on attachment 8529689 [details] [diff] [review]
Open Loop room conversation window right after it's created.

Approval Request Comment
Transfer request to beta
Attachment #8529689 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Attachment #8529689 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Tested extensively on Linux64 aurora and beta
Verified fixed FF 35b3, 36.0a2 (2014-12-16) Win 7
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.