Closed
Bug 1105520
Opened 9 years ago
Closed 9 years ago
Open the conversation window when I create a room
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox35 verified, firefox36 verified)
backlog | Fx35+ |
People
(Reporter: MattN, Unassigned)
References
Details
(Whiteboard: [needed for FTE/U])
Attachments
(1 file)
5.92 KB,
patch
|
mikedeboer
:
review+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
When a room is created, the conversation pane should open immediately according to the UX spec. I'm personally kind of on the fence for this since I don't want my webcam to come on just because I created a room that I may only want to use for a meeting in a week.
Updated•9 years ago
|
backlog: Fx35? → Fx35+
Priority: -- → P1
Whiteboard: [needed for FTE/U]
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → nperriault
Iteration: --- → 36.3
Points: --- → 2
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8529689 -
Flags: review?(mdeboer)
Comment 2•9 years ago
|
||
Comment on attachment 8529689 [details] [diff] [review] Open Loop room conversation window right after it's created. Review of attachment 8529689 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/loop/test/shared/roomStore_test.js @@ +79,5 @@ > copyString: function() {}, > rooms: { > create: function() {}, > getAll: function() {}, > + open: function() {}, perhaps it's good to sinon.stub() this and check if calledOnce() in your new test?
Attachment #8529689 -
Flags: review?(mdeboer) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Mike de Boer [:mikedeboer] from comment #2) > perhaps it's good to sinon.stub() this and check if calledOnce() in your new > test? It's already tested in #openRoom :)
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/67e4cff50baa
Target Milestone: --- → mozilla36
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/67e4cff50baa
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 6•9 years ago
|
||
Comment on attachment 8529689 [details] [diff] [review] Open Loop room conversation window right after it's created. Approval Request Comment [Feature/regressing bug #]: Rooms [User impact if declined]: Confusing flow for users - you create a room, share the link, but the notification someone entered it is subtle and may be missed. Users may assume it someone entering the room will pop a request like it did in the FF34 link-sharing UI, and they may assume it's broken. You can still leave a room after creating it. [Describe test coverage new/current, TBPL]: includes test [Risks and why]: low risk - just invokes a well-traveled path to pope open a room. After getting some experience in rooms we realized the flow was confusing. [String/UUID change made/needed]: none
Attachment #8529689 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
Comment on attachment 8529689 [details] [diff] [review] Open Loop room conversation window right after it's created. Approval Request Comment Transfer request to beta
Attachment #8529689 -
Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Updated•9 years ago
|
Attachment #8529689 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•9 years ago
|
||
Tested extensively on Linux64 aurora and beta
Comment 10•9 years ago
|
||
Verified fixed FF 35b3, 36.0a2 (2014-12-16) Win 7
You need to log in
before you can comment on or make changes to this bug.
Description
•