Closed
Bug 1105525
Opened 9 years ago
Closed 9 years ago
'Name this conversation' translations often cropped in room view because texts longer than English
Categories
(Hello (Loop) :: Client, defect, P1)
Tracking
(firefox35+ fixed, firefox36+ fixed, firefox37 fixed)
backlog | Fx35+ |
People
(Reporter: aryx, Unassigned)
Details
(Whiteboard: [l10n])
Attachments
(3 files, 1 obsolete file)
72.48 KB,
image/png
|
Details | |
85.51 KB,
image/png
|
Details | |
8.29 KB,
patch
|
standard8
:
review+
Sylvestre
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Firefox Aurora 20141126 on Windows 8.1 The localized texts for 'Name this conversation' are often too long to fit the available space. Current translations: http://transvision.mozfr.org/string/?entity=browser/chrome/browser/loop/loop.properties:rooms_name_this_room_label&repo=aurora
Updated•9 years ago
|
backlog: --- → Fx36?
Updated•9 years ago
|
Priority: -- → P1
Comment 1•9 years ago
|
||
How much of a problem is this? (If this needinfo should go to someone else, please redirect.) I tentatively have this in the F36 bucket.
Flags: needinfo?(sfranks)
Comment 2•9 years ago
|
||
What's the longest string we have? Might be simply a matter of slightly reducing the font size.
Flags: needinfo?(sfranks)
Comment 3•9 years ago
|
||
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #1) > How much of a problem is this? (If this needinfo should go to someone else, > please redirect.) I tentatively have this in the F36 bucket. Imagine cropping a string in a very prominent part of the UI for English, how would that feel? ;-) IMO there's plenty of space to have the text wrapping on two lines, and I expect to have truncated strings on several locales http://transvision.mozfr.org/string/?entity=browser/chrome/browser/loop/loop.properties:rooms_name_this_room_label&repo=beta On which version are conversations expected to be enabled?
Comment 4•9 years ago
|
||
Currently the "conversations" (a.k.a. "Rooms") UI is scheduled to go out in Fx35.
Comment 5•9 years ago
|
||
That's what I thought :-\ It would be really useful to target this for fx35 then, also considering that non en-US users are the majority out there.
Comment 6•9 years ago
|
||
Makes sense. Let's get this as good as we can in Fx35 and keep improving it in Fx36 and Fx37 in follow up bugs.
backlog: Fx36? → Fx35+
Comment 7•9 years ago
|
||
Sevaan -- Are you thinking of changing the layout for this screen like you will be doing in bug 1105708 / bug 1109866 ?
Flags: needinfo?(sfranks)
Comment 8•9 years ago
|
||
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #7) > Sevaan -- Are you thinking of changing the layout for this screen like you > will be doing in bug 1105708 / bug 1109866 ? Yes, we will need to do a review of this as the panel isn't working at peak efficiency. Problems: - Name this conversation text does not fit in other languages - Invite someone to join you text is too high above related buttons - Button widths can be bigger for larger targets - Even after I name a conversation, when I come back to this panel I still see a "Name this conversation" box. Now, having said this I'm not sure it's a major priority /right now/. I would say let's reduce the font size of "Name this conversation" and confirm that all locales fit, then revisit this very soon. Additionally, where can I find a list of all panels (preferably with screenshots) so I can do an overall panel review?
Flags: needinfo?(sfranks)
Comment 9•9 years ago
|
||
Hey Shell -- Can I ask you to work with Sevaan on his last request (in Comment 8)? He needs a list of all panels (preferably with screenshots) so he can do a overall panel review. We want to do this ASAP so we don't have any surprises in January. (We should file a new bug for this work.) Thanks!
Flags: needinfo?(sescalante)
Comment 10•9 years ago
|
||
Just updating bugzilla to match trello (and reality).
Assignee: nobody → nperriault
Assignee | ||
Comment 11•9 years ago
|
||
Attachment #8537275 -
Flags: review?(dmose)
Assignee | ||
Comment 12•9 years ago
|
||
Assignee | ||
Comment 13•9 years ago
|
||
Comment on attachment 8537275 [details] [diff] [review] Enlarge Loop room rename field to prevent l10n issues. Transfering review to some awaken timezone :)
Attachment #8537275 -
Flags: review?(dmose) → review?(standard8)
Assignee | ||
Comment 14•9 years ago
|
||
Unbitrotted patch.
Attachment #8537275 -
Attachment is obsolete: true
Attachment #8537275 -
Flags: review?(standard8)
Attachment #8537793 -
Flags: review?(standard8)
Comment 15•9 years ago
|
||
Comment on attachment 8537793 [details] [diff] [review] Enlarge Loop room rename field to prevent l10n issues. Patch v2 Review of attachment 8537793 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, this seems to work. r=Standard8
Attachment #8537793 -
Flags: review?(standard8) → review+
Assignee | ||
Comment 16•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/4ffe25a396c9
Iteration: --- → 37.1
Points: --- → 2
Assignee | ||
Updated•9 years ago
|
Target Milestone: --- → mozilla37
Comment 17•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4ffe25a396c9
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment 18•9 years ago
|
||
Comment on attachment 8537793 [details] [diff] [review] Enlarge Loop room rename field to prevent l10n issues. Patch v2 Approval Request Comment [Feature/regressing bug #]: Needed to change layout for certain foreign languages to not be cropped [User impact if declined]: Some foreign languages would have words cropped, making Hello tougher to use [Describe test coverage new/current, TBPL]: tbpl, manual testing [Risks and why]: Low risk to Hello, no risk outside of Hello [String/UUID change made/needed]: no strings
Attachment #8537793 -
Flags: approval-mozilla-beta?
Attachment #8537793 -
Flags: approval-mozilla-aurora?
Comment 19•9 years ago
|
||
[Tracking Requested - why for this release]: See Comment 18
status-firefox35:
--- → affected
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
tracking-firefox35:
--- → ?
tracking-firefox36:
--- → ?
Updated•9 years ago
|
Attachment #8537793 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8537793 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•9 years ago
|
Flags: needinfo?(sescalante)
You need to log in
before you can comment on or make changes to this bug.
Description
•