Closed Bug 1105525 Opened 5 years ago Closed 5 years ago

'Name this conversation' translations often cropped in room view because texts longer than English

Categories

(Hello (Loop) :: Client, defect, P1, trivial)

x86_64
Windows 8.1
defect
Points:
2

Tracking

(firefox35+ fixed, firefox36+ fixed, firefox37 fixed)

RESOLVED FIXED
mozilla37
Iteration:
37.1
Tracking Status
firefox35 + fixed
firefox36 + fixed
firefox37 --- fixed
Blocking Flags:
backlog Fx35+

People

(Reporter: aryx, Unassigned)

Details

(Whiteboard: [l10n])

Attachments

(3 files, 1 obsolete file)

Firefox Aurora 20141126 on Windows 8.1

The localized texts for 'Name this conversation' are often too long to fit the available space.

Current translations:
http://transvision.mozfr.org/string/?entity=browser/chrome/browser/loop/loop.properties:rooms_name_this_room_label&repo=aurora
Severity: normal → trivial
Whiteboard: [l10n]
backlog: --- → Fx36?
Priority: -- → P1
How much of a problem is this?  (If this needinfo should go to someone else, please redirect.)  I tentatively have this in the F36 bucket.
Flags: needinfo?(sfranks)
What's the longest string we have? Might be simply a matter of slightly reducing the font size.
Flags: needinfo?(sfranks)
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #1)
> How much of a problem is this?  (If this needinfo should go to someone else,
> please redirect.)  I tentatively have this in the F36 bucket.

Imagine cropping a string in a very prominent part of the UI for English, how would that feel? ;-)

IMO there's plenty of space to have the text wrapping on two lines, and I expect to have truncated strings on several locales
http://transvision.mozfr.org/string/?entity=browser/chrome/browser/loop/loop.properties:rooms_name_this_room_label&repo=beta

On which version are conversations expected to be enabled?
Currently the "conversations" (a.k.a. "Rooms") UI is scheduled to go out in Fx35.
That's what I thought :-\

It would be really useful to target this for fx35 then, also considering that non en-US users are the majority out there.
Makes sense.  Let's get this as good as we can in Fx35 and keep improving it in Fx36 and Fx37 in follow up bugs.
backlog: Fx36? → Fx35+
Sevaan -- Are you thinking of changing the layout for this screen like you will be doing in bug 1105708 / bug 1109866 ?
Flags: needinfo?(sfranks)
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #7)
> Sevaan -- Are you thinking of changing the layout for this screen like you
> will be doing in bug 1105708 / bug 1109866 ?

Yes, we will need to do a review of this as the panel isn't working at peak efficiency.

Problems:

- Name this conversation text does not fit in other languages
- Invite someone to join you text is too high above related buttons
- Button widths can be bigger for larger targets
- Even after I name a conversation, when I come back to this panel I still see a "Name this conversation" box.

Now, having said this I'm not sure it's a major priority /right now/. I would say let's reduce the font size of "Name this conversation" and confirm that all locales fit, then revisit this very soon.

Additionally, where can I find a list of all panels (preferably with screenshots) so I can do an overall panel review?
Flags: needinfo?(sfranks)
Hey Shell -- Can I ask you to work with Sevaan on his last request (in Comment 8)?  He needs a list of all panels (preferably with screenshots) so he can do a overall panel review.  We want to do this ASAP so we don't have any surprises in January.  (We should file a new bug for this work.)  Thanks!
Flags: needinfo?(sescalante)
Just updating bugzilla to match trello (and reality).
Assignee: nobody → nperriault
Comment on attachment 8537275 [details] [diff] [review]
Enlarge Loop room rename field to prevent l10n issues.

Transfering review to some awaken timezone :)
Attachment #8537275 - Flags: review?(dmose) → review?(standard8)
Unbitrotted patch.
Attachment #8537275 - Attachment is obsolete: true
Attachment #8537275 - Flags: review?(standard8)
Attachment #8537793 - Flags: review?(standard8)
Comment on attachment 8537793 [details] [diff] [review]
Enlarge Loop room rename field to prevent l10n issues. Patch v2

Review of attachment 8537793 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this seems to work. r=Standard8
Attachment #8537793 - Flags: review?(standard8) → review+
Target Milestone: --- → mozilla37
https://hg.mozilla.org/mozilla-central/rev/4ffe25a396c9
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment on attachment 8537793 [details] [diff] [review]
Enlarge Loop room rename field to prevent l10n issues. Patch v2

Approval Request Comment
[Feature/regressing bug #]: Needed to change layout for certain foreign languages to not be cropped
[User impact if declined]: Some foreign languages would have words cropped, making Hello tougher to use
[Describe test coverage new/current, TBPL]: tbpl, manual testing
[Risks and why]: Low risk to Hello, no risk outside of Hello
[String/UUID change made/needed]: no strings
Attachment #8537793 - Flags: approval-mozilla-beta?
Attachment #8537793 - Flags: approval-mozilla-aurora?
[Tracking Requested - why for this release]:
See Comment 18
Attachment #8537793 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8537793 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify-
Flags: needinfo?(sescalante)
You need to log in before you can comment on or make changes to this bug.