1105540 - Show tooltips for buttons 'Copy Link' and 'Delete conversation'

Status: RESOLVED FIXED

(Hello (Loop) :: Client, enhancement, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Add tooltips to the buttons for copying the link to a conversation or deleting the conversatio. The strings are already there in loop.properties.

rooms_list_copy_url_tooltip=Copy Link
rooms_list_delete_tooltip=Delete conversation

Comment 1

[Mark Banner (:standard8)]

Attachment: Show tooltips for buttons 'Copy Link' and 'Delete conversation'.

Simple patch for adding the tooltips.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8529364 [details] [diff] [review]
Show tooltips for buttons 'Copy Link' and 'Delete conversation'.

Review of attachment 8529364 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent.

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/c9d7496cb83b

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c9d7496cb83b

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8529364 [details] [diff] [review]
Show tooltips for buttons 'Copy Link' and 'Delete conversation'.

Approval Request Comment
[Feature/regressing bug #]: Loop Rooms - usability enhancement for the copy & delete buttons by describing what they are.
[User impact if declined]: None
[Describe test coverage new/current, TBPL]: Existing tests cover any breakage possibility
[Risks and why]: Very low - only adding a couple of attributes onto elements.
[String/UUID change made/needed]: None - strings already landed on aurora.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8529364 [details] [diff] [review]
Show tooltips for buttons 'Copy Link' and 'Delete conversation'.

Approval Request Comment
Transfer request to beta

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/613f90f01ad0