Closed
Bug 1105540
Opened 9 years ago
Closed 9 years ago
Show tooltips for buttons 'Copy Link' and 'Delete conversation'
Categories
(Hello (Loop) :: Client, enhancement, P1)
Hello (Loop)
Client
Tracking
(firefox35 fixed, firefox36 fixed)
backlog | Fx35+ |
People
(Reporter: aryx, Assigned: standard8)
Details
Attachments
(1 file)
2.18 KB,
patch
|
mikedeboer
:
review+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Add tooltips to the buttons for copying the link to a conversation or deleting the conversatio. The strings are already there in loop.properties. rooms_list_copy_url_tooltip=Copy Link rooms_list_delete_tooltip=Delete conversation
Assignee | ||
Comment 1•9 years ago
|
||
Simple patch for adding the tooltips.
Attachment #8529364 -
Flags: review?(mdeboer)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → standard8
Iteration: --- → 37.1
Points: --- → 1
Comment 2•9 years ago
|
||
Comment on attachment 8529364 [details] [diff] [review] Show tooltips for buttons 'Copy Link' and 'Delete conversation'. Review of attachment 8529364 [details] [diff] [review]: ----------------------------------------------------------------- Excellent.
Attachment #8529364 -
Flags: review?(mdeboer) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/c9d7496cb83b
Target Milestone: --- → mozilla36
Updated•9 years ago
|
backlog: --- → Fx35+
Priority: -- → P1
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c9d7496cb83b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8529364 [details] [diff] [review] Show tooltips for buttons 'Copy Link' and 'Delete conversation'. Approval Request Comment [Feature/regressing bug #]: Loop Rooms - usability enhancement for the copy & delete buttons by describing what they are. [User impact if declined]: None [Describe test coverage new/current, TBPL]: Existing tests cover any breakage possibility [Risks and why]: Very low - only adding a couple of attributes onto elements. [String/UUID change made/needed]: None - strings already landed on aurora.
Attachment #8529364 -
Flags: approval-mozilla-aurora?
Comment 6•9 years ago
|
||
Comment on attachment 8529364 [details] [diff] [review] Show tooltips for buttons 'Copy Link' and 'Delete conversation'. Approval Request Comment Transfer request to beta
Attachment #8529364 -
Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Updated•9 years ago
|
Attachment #8529364 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•