Closed
Bug 1105541
Opened 9 years ago
Closed 9 years ago
Fine-tune Lightweight theme colors on new tablet
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox36 verified, firefox37 verified)
VERIFIED
FIXED
Firefox 37
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(8 files)
1.71 MB,
image/png
|
Details | |
1.34 KB,
patch
|
mhaigh
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
613.41 KB,
image/png
|
Details | |
578.06 KB,
image/png
|
Details | |
3.07 KB,
patch
|
mhaigh
:
review+
|
Details | Diff | Splinter Review |
1.15 MB,
image/png
|
Details | |
6.50 KB,
patch
|
mhaigh
:
review+
|
Details | Diff | Splinter Review |
648.84 KB,
image/png
|
Details |
Issues I noticed after bug 1085771 lands: * The plus button in the tab strip is light and clashes with light themes * The grey text on the unselected tabs clashes with just about everything * (?) Back/forward button state when pressed/focused/etc. might look terrible * Pressed tab color in tab strip looks too dark on light themes
Assignee | ||
Comment 2•9 years ago
|
||
As long as I can get bug 1085771 to land soon, then yes, I think this is v1 material - it'll look pretty amateur if we don't get at least a dark/light swap working.
Flags: needinfo?(michael.l.comella)
Assignee | ||
Comment 4•9 years ago
|
||
I wonder if we shouldn't also change the icon colors (about:home favicon, close button, dividers) to a lighter color - maybe after bug 1105546. Note that we do mischaracterize (imo) some light themes as dark and vice versa, which makes this backfire sometimes.
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8535197 -
Flags: review?(mhaigh)
Assignee | ||
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
Assignee | ||
Comment 8•9 years ago
|
||
Attachment #8535218 -
Flags: review?(mhaigh)
Assignee | ||
Comment 9•9 years ago
|
||
Assignee | ||
Comment 10•9 years ago
|
||
Anthony, let me know if you have any objections to the screenshots in this bug.
Flags: needinfo?(alam)
Assignee | ||
Comment 11•9 years ago
|
||
The added assets are trimaged. To create the new assets, I ran: convert tab_new.png -background #5F6368 -alpha shape <out-file> where #5F6368 comes from the color I found for drawable-xhdpi/close.png.
Attachment #8535323 -
Flags: review?(mhaigh)
Comment 12•9 years ago
|
||
Comment on attachment 8535323 [details] [diff] [review] Part 3: Change add tab button to a dark color on light themes on new tablet Review of attachment 8535323 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me
Attachment #8535323 -
Flags: review?(mhaigh) → review+
Comment 13•9 years ago
|
||
Comment on attachment 8535218 [details] [diff] [review] Part 2: Add alpha to pressed state of tabs with LWT on new tablet Review of attachment 8535218 [details] [diff] [review]: ----------------------------------------------------------------- All good.
Attachment #8535218 -
Flags: review?(mhaigh) → review+
Updated•9 years ago
|
Attachment #8535197 -
Flags: review?(mhaigh) → review+
Comment 14•9 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #10) > Anthony, let me know if you have any objections to the screenshots in this > bug. Looks good to me. What opacity value are we using BTW? Just so we could reuse some of those numbers later if we need.
Flags: needinfo?(alam) → needinfo?(michael.l.comella)
Assignee | ||
Comment 15•9 years ago
|
||
(In reply to Anthony Lam (:antlam) from comment #14) > Looks good to me. What opacity value are we using BTW? Just so we could > reuse some of those numbers later if we need. For the pressed tabs, 170 / 255.
Flags: needinfo?(michael.l.comella)
Assignee | ||
Comment 16•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/f57690535a49 https://hg.mozilla.org/integration/fx-team/rev/6ecba299e659 https://hg.mozilla.org/integration/fx-team/rev/96e778e6b268
Assignee | ||
Comment 17•9 years ago
|
||
Comment on attachment 8535197 [details] [diff] [review] Part 1: Use a light text color for tab titles with a dark LWT on new tablet This request applies to parts 1-3, uplift dependency on bug 1085771. Approval Request Comment [Feature/regressing bug #]: New tablet release [User impact if declined]: New tablet UI will look unpolished w/ lightweight themes enabled. [Describe test coverage new/current, TBPL]: None [Risks and why]: We only touch lightweight theme code so somewhere along the line we could mess up the way lightweight themes work. [String/UUID change made/needed]: None
Attachment #8535197 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → affected
Comment 18•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f57690535a49 https://hg.mozilla.org/mozilla-central/rev/6ecba299e659 https://hg.mozilla.org/mozilla-central/rev/96e778e6b268
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8535197 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 19•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/52dfbfd086d0 https://hg.mozilla.org/releases/mozilla-aurora/rev/cd9788ebebcc https://hg.mozilla.org/releases/mozilla-aurora/rev/64c6aa56aa22
Comment 20•9 years ago
|
||
Verified as fixed in Firefox for Android 37.0a1 (2014-12-18) Firefox for Android 36.0a2 (2014-12-18) Device: Asus Transformer Pad TF300T (Android 4.2.1)
Comment 21•9 years ago
|
||
I can still see the behavior described in Bug 1110157, but only if you tap on the already selected tab; is this intended?
Flags: needinfo?(michael.l.comella)
Assignee | ||
Comment 22•9 years ago
|
||
(In reply to Mihai Pop from comment #21) > I can still see the behavior described in Bug 1110157, but only if you tap > on the already selected tab; is this intended? While I'm not sure I directly consulted :antlam on this one, yes, it is intended.
Flags: needinfo?(michael.l.comella)
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•