[Stingray][home] update visual of smart home to meet visual spec v2

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: johnhu, Assigned: johnhu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 attachment)

The visual spec had been updated in these two days. Information block part had been updated. Since the bug 1101369 had been r+, I would like to land that first and use this issue to update it.
Assignee: nobody → im
The following had been changed:
1. background
2. font-style
3. information block
4. icon-fonts
Summary: [Stingray][home] update visual to information block → [Stingray][home] update visual of smart home to meet visual spec v2
I will create a PR to update all of them.
Created attachment 8531590 [details] [review]
update visual to comply visual spec v2

dwi2,

This patch depends on the patch of bug 1101373. I had also included it in this PR. So, please just review the second commit and I will remove it once we have finished the review or bug 1101373 landed.
Attachment #8531590 - Flags: review?(tzhuang)
Depends on: 1101373
Comment on attachment 8531590 [details] [review]
update visual to comply visual spec v2

Rex,

Please review this patch and please only review the second commit because the first commit should be reviewed by dwi2. Thanks.
Attachment #8531590 - Flags: review?(tzhuang) → review?(rexboy)
Comment on attachment 8531590 [details] [review]
update visual to comply visual spec v2

Sorry for the late review. Looks good to me.
Attachment #8531590 - Flags: review?(rexboy) → review+
merged to master:
https://github.com/mozilla-b2g/gaia/commit/6612c44e541a3ee5bfd8bd0bf6d5fd9bb577cdfb

gaia-try is all green:
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=f8c3770d6f0d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.