Closed Bug 1105588 Opened 5 years ago Closed 5 years ago
[Stingray][System] allow "-" in oop black list
In our regular expression, we use: host.replace(/(^[\w\d]+\.)?([\w\d]+\.[a-z]+)/, '$2'), no "-" in there.
steal from John
Assignee: im → tzhuang
Hi John, Would you please help to review the patch? Thanks
Attachment #8529606 - Flags: review?(im)
Comment on attachment 8529606 [details] [review] pull request Thanks for this patch. BTW, this issue may not block CardUI bug since we don't need to put smart-home as OOP black list. We should file a bug called CardUI-Followup to trace this kind of bugs.
Attachment #8529606 - Flags: review?(im) → review+
Thanks, and I filed a bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105935 for it
landed on master https://github.com/mozilla-b2g/gaia/commit/4abc74bd7056e1924b21ddfeaf5b81964a970467
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
According to comment 3, this should not block CardUI.
You need to log in before you can comment on or make changes to this bug.