1105596 - simplify aboutNetError_info.svg

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: patch

The important change is from fill:transparent to fill:none.  These are handled differently and the latter will skip a small amount of work.

Removed a bunch of attributes that are unnecessary too.

Comment 1

[:Gijs (he/him)]

Comment on attachment 8529447 [details] [diff] [review]
patch

Review of attachment 8529447 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming this doesn't affect any of the caching, sure.

I wonder if you have time to look at browser/themes/shared/aboutNetError_alert.svg in aurora. We'll need that on central soon, and I bet it can use similar treatment - just not the same, because of it being a different image...

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Did this get forgotten?

Comment 3

[Cameron McCormack (:heycam)]

(In reply to :Gavin Sharp [email: [e-mail]] from comment #2)
> Did this get forgotten?

It did.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f64f1e85e7c

Comment 4

[Cameron McCormack (:heycam)]

(In reply to Gijs Kruitbosch (Gone until Jan 5) from comment #1)
> I wonder if you have time to look at
> browser/themes/shared/aboutNetError_alert.svg in aurora. We'll need that on
> central soon, and I bet it can use similar treatment - just not the same,
> because of it being a different image...

This is now on beta.  While the file could be trimmed down a bit, it doesn't use fill:transparent, so maybe I should just leave it.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6f64f1e85e7c