[Stingray][Home] Use correct icon of decks in Smart Home

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dwi2, Assigned: dwi2)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We should use correct icon instead of white icon for decks, and remove unused app from whitelist: smart-home.js
(Assignee)

Updated

3 years ago
Whiteboard: [ft:conndevices]
(Assignee)

Updated

3 years ago
Blocks: 1101329
(Assignee)

Updated

3 years ago
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8529595 [details] [review]
pull request

Hi Rex,

Please help to review the patch. We use correct deck icons in this patch.
Attachment #8529595 - Flags: review?(rexboy)
Comment on attachment 8529595 [details] [review]
pull request

Please file a bug to track that icons for incomplete decks should be moved out to each deck once they are finished. (I'm not sure if they need to be in TTF or PNG though, but let's keep track of it first)
Attachment #8529595 - Flags: review?(rexboy) → review+
(Assignee)

Updated

3 years ago
Blocks: 1105934
(Assignee)

Comment 3

3 years ago
Thanks.

Landed on master
https://github.com/mozilla-b2g/gaia/commit/7df872599c20d9f66c4f99265969ffbfd17cf1fe
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.