Closed Bug 1105629 Opened 5 years ago Closed 5 years ago

[Stingray][Home] Use correct icon of decks in Smart Home

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dwi2, Assigned: dwi2)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
rexboy
: review+
Details | Review
We should use correct icon instead of white icon for decks, and remove unused app from whitelist: smart-home.js
Whiteboard: [ft:conndevices]
Blocks: 1101329
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Attached file pull request
Hi Rex,

Please help to review the patch. We use correct deck icons in this patch.
Attachment #8529595 - Flags: review?(rexboy)
Comment on attachment 8529595 [details] [review]
pull request

Please file a bug to track that icons for incomplete decks should be moved out to each deck once they are finished. (I'm not sure if they need to be in TTF or PNG though, but let's keep track of it first)
Attachment #8529595 - Flags: review?(rexboy) → review+
Blocks: 1105934
Thanks.

Landed on master
https://github.com/mozilla-b2g/gaia/commit/7df872599c20d9f66c4f99265969ffbfd17cf1fe
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.