Closed
Bug 1105661
Opened 9 years ago
Closed 9 years ago
MP4Sample: use of delete in place of delete[]
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: jya, Assigned: jya)
Details
Attachments
(1 file)
857 bytes,
patch
|
ajones
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Noticed while working on bug 1101534
Assignee | ||
Comment 1•9 years ago
|
||
It's an array extra_buffer points to, so it should be a nsAutoArrayPtr.
Attachment #8529660 -
Flags: review?(ajones)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Updated•9 years ago
|
Attachment #8529660 -
Flags: review?(ajones) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=28d3deb38a66
Keywords: checkin-needed
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/635de985beb9
Keywords: checkin-needed
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/635de985beb9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment 5•9 years ago
|
||
Comment on attachment 8529660 [details] [diff] [review] MP4Sample: use proper delete[] operator Approval Request Comment [Feature/regressing bug #]: MSE [User impact if declined]: Less consistent playback support, video sites more likely to use flash. [Describe test coverage new/current, TBPL]: Landed on m-c. [Risks and why]: Low. Fixes a dtor issue. [String/UUID change made/needed]: None
Attachment #8529660 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
Updated•9 years ago
|
Attachment #8529660 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•9 years ago
|
||
Backed out and relanded to fix commit message corruption. https://hg.mozilla.org/releases/mozilla-aurora/rev/676eee1ff92c https://hg.mozilla.org/releases/mozilla-aurora/rev/396b0e2607bc
You need to log in
before you can comment on or make changes to this bug.
Description
•