Closed
Bug 1105698
Opened 9 years ago
Closed 9 years ago
On the standalone, you can see a brief flash of the feedback smiles upon leaving a Rooms URL
Categories
(Hello (Loop) :: Client, defect, P1)
Tracking
(firefox35+ fixed, firefox36 fixed, firefox37 fixed)
backlog | Fx37? |
People
(Reporter: mreavy, Unassigned)
References
Details
(Whiteboard: [UX bug][stand-alone])
Attachments
(1 file, 1 obsolete file)
2.82 KB,
patch
|
standard8
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
From a Rooms URL on the standalone side, if you browse somewhere else (e.g. Home), the feedback smiles appear briefly before the new screen (e.g. home screen) paints.
Reporter | ||
Updated•9 years ago
|
backlog: --- → Fx35+
Priority: -- → P1
Reporter | ||
Comment 1•9 years ago
|
||
[Tracking Requested - why for this release]: This patch is for the standalone app. We may choose to uplift it for the sake of shared code with desktop. Marking this as tracking Fx35 so we get this fixed before Fx35 goes to Release.
tracking-firefox35:
--- → ?
Updated•9 years ago
|
backlog: Fx35+ → Fx37?
Whiteboard: [UX bug][stand-alone]
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → nperriault
Iteration: --- → 37.1
Points: --- → 1
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8531658 -
Flags: review?(standard8)
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8531658 [details] [diff] [review] Bug 947018: Unbreak testBrowserProvider. Erroneous patch, will resubmit the right one soon.
Attachment #8531658 -
Flags: review?(standard8)
Assignee | ||
Comment 4•9 years ago
|
||
Correct patch.
Attachment #8531658 -
Attachment is obsolete: true
Attachment #8531671 -
Flags: review?(standard8)
Comment 5•9 years ago
|
||
Comment on attachment 8531671 [details] [diff] [review] Fixed brief fickering of feedback form in Loop standalone. Looks good, r=Standard8
Attachment #8531671 -
Flags: review?(standard8) → review+
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/aec38e8b60da
Target Milestone: --- → mozilla37
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/aec38e8b60da
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 8•9 years ago
|
||
Comment on attachment 8531671 [details] [diff] [review] Fixed brief fickering of feedback form in Loop standalone. Approval Request Comment [Feature/regressing bug #]: Feedback in Rooms Standalone [User impact if declined]: Merge issues with code that touches activeRoomStore [Describe test coverage new/current, TBPL]: Includes test [Risks and why]: minimal to none (touches shared code) [String/UUID change made/needed]: none
Attachment #8531671 -
Flags: approval-mozilla-beta?
Attachment #8531671 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8531671 -
Flags: approval-mozilla-beta?
Attachment #8531671 -
Flags: approval-mozilla-beta+
Attachment #8531671 -
Flags: approval-mozilla-aurora?
Attachment #8531671 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•