Texts/labels of buttons to mail/copy link if there was an issue with conversation cropped in some locales

RESOLVED FIXED in Firefox 35

Status

Hello (Loop)
Client
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: aryx, Unassigned)

Tracking

unspecified
mozilla37
x86_64
Windows 8.1
Points:
1
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox35 fixed, firefox36 fixed, firefox37 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Created attachment 8529738 [details]
screenshot of issue for German

Firefox 35.0a2 20141126 on Windows 8.1

In some locales, the labels of the buttons to mail or copy the link of the conversation if there was an issue with conversation get cropped because they are longer than in en-US. See attached screenshot for German.
backlog: --- → Fx36?
Priority: -- → P1
How much of a problem is this?  (If this needinfo should go to someone else, please redirect.)  I tentatively have this in the F36 bucket.
Flags: needinfo?(sfranks)
Per discussion in Bug 1105525, we want to do improve this for Fx35.
backlog: Fx36? → Fx35+
Depends on: 1109866
I would say this is a fairly major problem. We wouldn't ship this if the English buttons were cut off as it doesn't present clear options to the user.

I think it's just a matter of redesigning this panel as there are a number of places for improvement. I have created Bug 1109866 to track this.
Flags: needinfo?(sfranks)
Just updating bugzilla to match trello (and reality).
Assignee: nobody → nperriault
Created attachment 8537797 [details] [diff] [review]
More l10n compliant buttons.
Attachment #8537797 - Flags: review?(standard8)
Comment on attachment 8537797 [details] [diff] [review]
More l10n compliant buttons.

Review of attachment 8537797 [details] [diff] [review]:
-----------------------------------------------------------------

One minor issue, but otherwise I like the general idea of the patch.

::: browser/components/loop/content/shared/css/conversation.css
@@ -258,5 @@
>    width: 100%;
>  }
>  
>  .call-action-group > .btn {
> -  height: 26px;

Removing this seems to affect the height of the cancel button in the "Connecting" view of the PendingConversationView.

Also, if I make all the text short one-words, then the buttons are short as well.

How about making this a min-height?
Attachment #8537797 - Flags: review?(standard8) → review-
Created attachment 8539224 [details] [diff] [review]
More l10n compliant buttons.

(In reply to Mark Banner (:standard8) from comment #7)
> How about making this a min-height?
Great idea!
Attachment #8537797 - Attachment is obsolete: true
Attachment #8539224 - Flags: review?(standard8)
Comment on attachment 8539224 [details] [diff] [review]
More l10n compliant buttons.

Transferring review to Mike as Mark is on PTO today and we want this to be uplifted before Monday.
Attachment #8539224 - Flags: review?(standard8) → review?(mdeboer)
Comment on attachment 8539224 [details] [diff] [review]
More l10n compliant buttons.

Review of attachment 8539224 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it!
Attachment #8539224 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/integration/fx-team/rev/5312b07dd7e4
Iteration: --- → 37.1
Points: --- → 1
Target Milestone: --- → mozilla37

Updated

3 years ago
status-firefox35: --- → affected
status-firefox36: --- → affected
status-firefox37: --- → affected
Comment on attachment 8539224 [details] [diff] [review]
More l10n compliant buttons.

Approval Request Comment
[Feature/regressing bug #]: Rooms

[User impact if declined]: Hard for localizers to create reasonable localized versions due to lack of space.

[Describe test coverage new/current, TBPL]: on fxteam; will merge to m-c shortly

[Risks and why]: Low risk - visual change; mostly CSS

[String/UUID change made/needed]: none
Attachment #8539224 - Flags: approval-mozilla-beta?
Attachment #8539224 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/5312b07dd7e4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
status-firefox37: affected → fixed
Attachment #8539224 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8539224 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Updated

3 years ago
status-firefox36: affected → fixed

Updated

3 years ago
status-firefox35: affected → fixed
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.