1105708 - Texts/labels of buttons to mail/copy link if there was an issue with conversation cropped in some locales

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot of issue for German

Firefox 35.0a2 20141126 on Windows 8.1

In some locales, the labels of the buttons to mail or copy the link of the conversation if there was an issue with conversation get cropped because they are longer than in en-US. See attached screenshot for German.

Comment 1

[Maire Reavy [:mreavy]]

How much of a problem is this?  (If this needinfo should go to someone else, please redirect.)  I tentatively have this in the F36 bucket.

Comment 2

[Maire Reavy [:mreavy]]

Per discussion in Bug 1105525, we want to do improve this for Fx35.

Comment 3

[Sevaan Franks [:sevaan]]

I would say this is a fairly major problem. We wouldn't ship this if the English buttons were cut off as it doesn't present clear options to the user.

I think it's just a matter of redesigning this panel as there are a number of places for improvement. I have created Bug 1109866 to track this.

Comment 4

[Maire Reavy [:mreavy]]

Just updating bugzilla to match trello (and reality).

Comment 5

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: More l10n compliant buttons.

Comment 6

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: capture with patch applied

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8537797 [details] [diff] [review]
More l10n compliant buttons.

Review of attachment 8537797 [details] [diff] [review]:
-----------------------------------------------------------------

One minor issue, but otherwise I like the general idea of the patch.

::: browser/components/loop/content/shared/css/conversation.css
@@ -258,5 @@
>    width: 100%;
>  }
>  
>  .call-action-group > .btn {
> -  height: 26px;

Removing this seems to affect the height of the cancel button in the "Connecting" view of the PendingConversationView.

Also, if I make all the text short one-words, then the buttons are short as well.

How about making this a min-height?

Comment 8

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: More l10n compliant buttons.

(In reply to Mark Banner (:standard8) from comment #7)
> How about making this a min-height?
Great idea!

Comment 9

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8539224 [details] [diff] [review]
More l10n compliant buttons.

Transferring review to Mike as Mark is on PTO today and we want this to be uplifted before Monday.

Comment 10

[Mike de Boer [:mikedeboer]]

Comment on attachment 8539224 [details] [diff] [review]
More l10n compliant buttons.

Review of attachment 8539224 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it!

Comment 11

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

https://hg.mozilla.org/integration/fx-team/rev/5312b07dd7e4

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8539224 [details] [diff] [review]
More l10n compliant buttons.

Approval Request Comment
[Feature/regressing bug #]: Rooms

[User impact if declined]: Hard for localizers to create reasonable localized versions due to lack of space.

[Describe test coverage new/current, TBPL]: on fxteam; will merge to m-c shortly

[Risks and why]: Low risk - visual change; mostly CSS

[String/UUID change made/needed]: none

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5312b07dd7e4

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/85cab59dd374

Comment 15

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a7f55dd6655c