1105727 - Investigate JQuery.event.trigger not getting ion compiled

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Hannes Verschore [:h4writer]]

Browsermark spends 200ms (12%) in JQuery.event.trigger (jquery 2.0.3 line 4464). Looking at the logs, we don't ion compile that function: "abort during SSA construction.".

Investigate and fix!

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: Mark as not inlining instead of erroring

Comment 2

[Jan de Mooij [:jandem]]

Nice find, Hannes. I think we should backport this to aurora and beta...

Comment 3

[Hannes Verschore [:h4writer]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f0b3e9ddba5

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8f0b3e9ddba5

Comment 5

[Hannes Verschore [:h4writer]]

Comment on attachment 8530682 [details] [diff] [review]
Mark as not inlining instead of erroring

Approval Request Comment
[Feature/regressing bug #]:
bug 977966

[User impact if declined]:
Severe possible regression in performance when using "array.join()" in non-optimal conditions. (100x slower and affecting the whole function the array.join is used).

[Describe test coverage new/current, TBPL]:
Landed on inbound/central.

[Risks and why]: 
I would say no risk. Very easy and straightforward patch. It now takes the normal (don't inline) path, instead of throwing an error. Which is already tested by a lot of other functions. This is also the path it took before bug 977966 happened.

[String/UUID change made/needed]:
/

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/47f89c9a5fe0
https://hg.mozilla.org/releases/mozilla-beta/rev/8ea69a2b5f12