Closed
Bug 1105727
Opened 9 years ago
Closed 9 years ago
Investigate JQuery.event.trigger not getting ion compiled
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: h4writer, Assigned: h4writer)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.07 KB,
patch
|
nbp
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Browsermark spends 200ms (12%) in JQuery.event.trigger (jquery 2.0.3 line 4464). Looking at the logs, we don't ion compile that function: "abort during SSA construction.". Investigate and fix!
Assignee | ||
Comment 1•9 years ago
|
||
Assignee: nobody → hv1989
Attachment #8530682 -
Flags: review?(nicolas.b.pierron)
Comment 2•9 years ago
|
||
Nice find, Hannes. I think we should backport this to aurora and beta...
Blocks: 977966
Updated•9 years ago
|
Attachment #8530682 -
Flags: review?(nicolas.b.pierron) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f0b3e9ddba5
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8f0b3e9ddba5
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8530682 [details] [diff] [review] Mark as not inlining instead of erroring Approval Request Comment [Feature/regressing bug #]: bug 977966 [User impact if declined]: Severe possible regression in performance when using "array.join()" in non-optimal conditions. (100x slower and affecting the whole function the array.join is used). [Describe test coverage new/current, TBPL]: Landed on inbound/central. [Risks and why]: I would say no risk. Very easy and straightforward patch. It now takes the normal (don't inline) path, instead of throwing an error. Which is already tested by a lot of other functions. This is also the path it took before bug 977966 happened. [String/UUID change made/needed]: /
Attachment #8530682 -
Flags: approval-mozilla-beta?
Attachment #8530682 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8530682 -
Flags: approval-mozilla-beta?
Attachment #8530682 -
Flags: approval-mozilla-beta+
Attachment #8530682 -
Flags: approval-mozilla-aurora?
Attachment #8530682 -
Flags: approval-mozilla-aurora+
Comment 6•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/47f89c9a5fe0 https://hg.mozilla.org/releases/mozilla-beta/rev/8ea69a2b5f12
You need to log in
before you can comment on or make changes to this bug.
Description
•