Closed Bug 1105727 Opened 5 years ago Closed 5 years ago
.event .trigger not getting ion compiled
Browsermark spends 200ms (12%) in JQuery.event.trigger (jquery 2.0.3 line 4464). Looking at the logs, we don't ion compile that function: "abort during SSA construction.". Investigate and fix!
Assignee: nobody → hv1989
Attachment #8530682 - Flags: review?(nicolas.b.pierron)
Nice find, Hannes. I think we should backport this to aurora and beta...
Attachment #8530682 - Flags: review?(nicolas.b.pierron) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8530682 [details] [diff] [review] Mark as not inlining instead of erroring Approval Request Comment [Feature/regressing bug #]: bug 977966 [User impact if declined]: Severe possible regression in performance when using "array.join()" in non-optimal conditions. (100x slower and affecting the whole function the array.join is used). [Describe test coverage new/current, TBPL]: Landed on inbound/central. [Risks and why]: I would say no risk. Very easy and straightforward patch. It now takes the normal (don't inline) path, instead of throwing an error. Which is already tested by a lot of other functions. This is also the path it took before bug 977966 happened. [String/UUID change made/needed]: /
You need to log in before you can comment on or make changes to this bug.