Closed Bug 1105748 Opened 10 years ago Closed 9 years ago

Fix Mn failure on emulator/device (wrappedJSObject.System is undefined)

Categories

(Remote Protocol :: Marionette, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37

People

(Reporter: mdas, Assigned: mdas)

References

Details

(Keywords: pi-marionette-runner)

Attachments

(2 files, 1 obsolete file)

Attached patch fix_testcon (obsolete) — Splinter Review
we get:

W/GeckoConsole(  209): [JavaScript Error: "TypeError: window.wrappedJSObject.System is undefined" {file: "dummy file" line: 8}]

whenever running the Mn tests in a test container because the currentApp has been moved to Service, and is no longer accessible in System.

try:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ad396d4bf576
Attachment #8529761 - Flags: review?(jgriffin)
Comment on attachment 8529761 [details] [diff] [review]
fix_testcon

Review of attachment 8529761 [details] [diff] [review]:
-----------------------------------------------------------------

the loop and layout tests shouldnt be removed. r+ with those added back
Attachment #8529761 - Flags: review?(jgriffin) → review+
Attached patch fix_testconSplinter Review
fixed, carrying r+ forward
Attachment #8529761 - Attachment is obsolete: true
Attachment #8529765 - Flags: review+
Attached patch fix navigationSplinter Review
try failed due to navigation in chrome test failure. I have a patch I want to test but all the trees are closed. parking patch here and ni?ing myself to get back to this
Flags: needinfo?(mdas)
Comment on attachment 8529896 [details] [diff] [review]
fix navigation

https://tbpl.mozilla.org/?tree=Try&rev=d748723ac0b9 try looks good!
Flags: needinfo?(mdas)
Attachment #8529896 - Flags: review?(dburns)
Attachment #8529896 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/5befd8bc6074
Assignee: nobody → mdas
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: