1105802 - Add Beta tag to the Rooms standalone page

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Maire Reavy [:mreavy]]

Since the feature is still in Beta during Fx35, we want to add the Beta ribbon to the Rooms standalone page.  We want to do this before the next update of the standalone app

Comment 1

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Added beta tag to standalone room layout.

Minimalistic approach. Note that the issue with RWD will be addressed along bug 1104051.

Comment 2

[Maire Reavy [:mreavy]]

Thanks, Niko!

Comment 3

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Added beta tag to standalone room layout. Patch v2

Fixed regression introduced by previous patch.

Comment 4

[Maire Reavy [:mreavy]]

[Tracking Requested - why for this release]:
This patch is for the standalone app. We may choose to uplift it for the sake of shared code with desktop.  Marking this as tracking Fx35 so we get this fixed before Fx35 goes to Release.

Comment 5

[Maire Reavy [:mreavy]]

Comment on attachment 8530317 [details] [diff] [review]
Added beta tag to standalone room layout. Patch v2

I'd like us to land the remaining open Rooms bugs this week.  This just needs a review from Mike or Mark to land (whoever gets to it first).

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8530317 [details] [diff] [review]
Added beta tag to standalone room layout. Patch v2

r=dmose with a comment added about what factors influenced the choice of 50px.  If it makes sense to switch to rems for scalability, I'd be ok with that too.

Comment 7

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Added beta tag to standalone room layout.

I discovered an issue with that patch when resizing the browser window where the Firefox logo was hidden entirely; so here's new version of the patch fixing that situation.

Re commenting on the 50px value, I don't have a clue how to explain that choice except "because it's where it looks best"… Converting to rem wouldn't improve scalability as we're speaking svg and background here.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8531738 [details] [diff] [review]
Added beta tag to standalone room layout.

r=dmose

Comment 9

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

https://hg.mozilla.org/integration/fx-team/rev/656951a75391

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/656951a75391

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8531738 [details] [diff] [review]
Added beta tag to standalone room layout.

Approval Request Comment
[Feature/regressing bug #]: Rooms standalone

[User impact if declined]: minor merge conflicts possible in future patches

[Describe test coverage new/current, TBPL]: manual test, on m-c

[Risks and why]: no risk, pure standalone 

[String/UUID change made/needed]: none

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a408c98d4f5d

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9ddd28e950d0