1105808 - browser_fontinspector.js is going to permafail when Gecko 36 merges to Beta

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=53592582&tree=Try

23:37:14     INFO -  647 INFO TEST-START | chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js
23:37:15     INFO -  648 INFO checking window state
23:37:15     INFO -  649 INFO Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://mochi.test:8888/browser/browser/devtools/fontinspector/test/browser_fontinspector.html" line: 0}]
23:37:15     INFO -  650 INFO Console message: [JavaScript Error: "downloadable font: download failed (font-family: "bar" style:normal weight:normal stretch:normal src index:0): status=2147746065 source: http://mochi.test:8888/browser/browser/devtools/fontinspector/test/bad/font/name.ttf" {file: "http://mochi.test:8888/browser/browser/devtools/fontinspector/test/browser_fontinspector.html" line: 4 column: 14 source: "@font-face {
23:37:15     INFO -    font-family: "bar";
23:37:15     INFO -    src: url("bad/font/name.ttf"), url("ostrich-regular.woff") format("woff");
23:37:15     INFO -  }"}]
23:37:15     INFO -  651 INFO Opening the inspector
23:37:15     INFO -  652 INFO Opening the toolbox
23:37:15     INFO -  653 INFO Console message: [JavaScript Error: "downloadable font: rejected by sanitizer (font-family: "bar" style:normal weight:normal stretch:normal src index:1) source: http://mochi.test:8888/browser/browser/devtools/fontinspector/test/ostrich-regular.woff" {file: "http://mochi.test:8888/browser/browser/devtools/fontinspector/test/browser_fontinspector.html" line: 4 column: 14 source: "@font-face {
23:37:15     INFO -    font-family: "bar";
23:37:15     INFO -    src: url("bad/font/name.ttf"), url("ostrich-regular.woff") format("woff");
23:37:15     INFO -  }"}]
23:37:15     INFO -  654 INFO Making sure that the toolbox's frame is focused
23:37:15     INFO -  655 INFO Waiting for the inspector to update
23:37:15     INFO -  656 INFO Console message: [JavaScript Warning: "Expected color but found 'arial'.  Error in parsing value for 'color'.  Declaration dropped." {file: "resource://gre-resources/hiddenWindow.html" line: 0 column: 0 source: "arial"}]
23:37:15     INFO -  657 INFO Console message: [JavaScript Warning: "Expected color but found 'arial'.  Error in parsing value for 'color'.  Declaration dropped." {file: "resource://gre-resources/hiddenWindow.html" line: 0 column: 0 source: "arial"}]
23:37:15     INFO -  658 INFO Selecting the test node
23:37:15     INFO -  659 INFO Selecting the node for 'body'
23:37:15     INFO -  660 INFO Console message: [JavaScript Warning: "Expected color but found 'arial'.  Error in parsing value for 'color'.  Declaration dropped." {file: "resource://gre-resources/hiddenWindow.html" line: 0 column: 0 source: "arial"}]
23:37:15     INFO -  661 INFO Console message: [JavaScript Warning: "Expected color but found 'arial'.  Error in parsing value for 'color'.  Declaration dropped." {file: "resource://gre-resources/hiddenWindow.html" line: 0 column: 0 source: "arial"}]
23:37:15     INFO -  662 INFO Console message: [JavaScript Warning: "Expected color but found 'arial'.  Error in parsing value for 'color'.  Declaration dropped." {file: "resource://gre-resources/hiddenWindow.html" line: 0 column: 0 source: "arial"}]
23:37:15     INFO -  663 INFO Console message: [JavaScript Warning: "Expected color but found 'arial'.  Error in parsing value for 'color'.  Declaration dropped." {file: "resource://gre-resources/hiddenWindow.html" line: 0 column: 0 source: "arial"}]
23:37:15     INFO -  664 INFO Font Inspector ready
23:37:15     INFO -  665 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js | Font inspector document is alive.
23:37:15     INFO -  666 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js | Found 2 fonts
23:37:15     INFO -  667 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js | font 0: Right font name - Got DejaVu Serif, expected Ostrich Sans Medium
23:37:15     INFO -  Stack trace:
23:37:15     INFO -      chrome://mochikit/content/browser-test.js:test_is:834
23:37:15     INFO -      chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js:testBodyFonts:45
23:37:15     INFO -      self-hosted:next:583
23:37:15     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23
23:37:15     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7
23:37:15     INFO -      this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37
23:37:15     INFO -  668 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js | font 0: is remote -
23:37:15     INFO -  Stack trace:
23:37:15     INFO -      chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js:testBodyFonts:47
23:37:15     INFO -      self-hosted:next:583
23:37:15     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23
23:37:15     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7
23:37:15     INFO -      this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37
23:37:15     INFO -  669 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js | font 0: right url - Got , expected http://mochi.test:8888/browser/browser/devtools/fontinspector/test/ostrich-regular.woff
23:37:15     INFO -  Stack trace:
23:37:15     INFO -      chrome://mochikit/content/browser-test.js:test_is:834
23:37:15     INFO -      chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js:testBodyFonts:49
23:37:15     INFO -      self-hosted:next:583
23:37:15     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23
23:37:15     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7
23:37:15     INFO -      this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37
23:37:15     INFO -  670 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js | font 0: right font format - Got , expected woff
23:37:15     INFO -  Stack trace:
23:37:15     INFO -      chrome://mochikit/content/browser-test.js:test_is:834
23:37:15     INFO -      chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js:testBodyFonts:52
23:37:15     INFO -      self-hosted:next:583
23:37:15     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23
23:37:15     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7
23:37:15     INFO -      this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37
23:37:15     INFO -  671 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js | font 0: right css name - Got DejaVu Serif, expected bar
23:37:15     INFO -  Stack trace:
23:37:15     INFO -      chrome://mochikit/content/browser-test.js:test_is:834
23:37:15     INFO -      chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js:testBodyFonts:54
23:37:15     INFO -      self-hosted:next:583
23:37:15     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23
23:37:15     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7
23:37:15     INFO -      this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37
23:37:15     INFO -  672 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js | font 1: Right font name
23:37:15     INFO -  673 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js | font 2: is local
23:37:15     INFO -  674 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js | Arial
23:37:15     INFO -  675 INFO Selecting the node for 'div'
23:37:15     INFO -  676 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js | Found 1 font on DIV
23:37:15     INFO -  677 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js | The DIV font has the right name - Got DejaVu Serif, expected Ostrich Sans Medium
23:37:15     INFO -  Stack trace:
23:37:15     INFO -      chrome://mochikit/content/browser-test.js:test_is:834
23:37:15     INFO -      chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js:testDivFonts:77
23:37:15     INFO -      self-hosted:InterpretGeneratorResume:657
23:37:15     INFO -      self-hosted:next:583
23:37:15     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23
23:37:15     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7
23:37:15     INFO -      this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37
23:37:16     INFO -  678 INFO TEST-OK | chrome://mochitests/content/browser/browser/devtools/fontinspector/test/browser_fontinspector.js | took 2486ms

Comment 1

[Heather Arthur [:harth]]

Ryan, can you explain why this will become a permafail on Beta? Is there some test setting that's special there? I say this because I haven't seen this failure before.

Comment 2

[Phil Ringnalda (:philor)]

Beta defines (by virtue of the version number change which drops the a from aurora) RELEASE_BUILD, http://mxr.mozilla.org/mozilla-central/source/configure.in#3513. http://mxr.mozilla.org/mozilla-central/search?string=release_build makes far far too many changes, because we like to ship half-done things to aurora as well as nightly.

Fonts? Perhaps you're being tripped up by the result of http://mxr.mozilla.org/mozilla-central/source/modules/libpref/init/all.js#570?

Comment 3

[Heather Arthur [:harth]]

Attachment: Enable woff2 just for the test

Thanks philor. It's definitely that pref.

I used WOFF 2 fonts for the test because they were much smaller in size. This patch just enables woff 2 for the test and resets the pref at the end of it.

Comment 4

[Heather Arthur [:harth]]

Attachment: Use ttf instead

Brian suggested we just change the font files to something enabled by default. I found ttf files for Ostrich.

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8531747 [details] [diff] [review]
Use ttf instead

Review of attachment 8531747 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me as long as it passes on beta (it seems like it should).  Please make sure the woff files are removed from the tree also.

Comment 6

[Heather Arthur [:harth]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f4ea6fe61455

Comment 7

[Heather Arthur [:harth]]

Attachment: Patch to check in that removes old woff files

Here's the patch from try, that removes the old files as well.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/ae81d513bb7c

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ae81d513bb7c

Comment 10

[Heather Arthur [:harth]]

Comment on attachment 8532171 [details] [diff] [review]
Patch to check in that removes old woff files

I assume this needs to get on Aurora to prevent the permafail.

Approval Request Comment
[Feature/regressing bug #]:
bug 886041

[User impact if declined]:
Test will permafail when aurora goes to Beta, causing developer stress.

[Describe test coverage new/current, TBPL]:
Been on mozilla-central for a few days.

[Risks and why]: 
Only affects tests

[String/UUID change made/needed]:
None

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e5c81630cb9b

Comment 12

[Ryan VanderMeulen [:RyanVM]]

No occurrences in my latest Try runs, thanks :)