Closed Bug 1105809 Opened 5 years ago Closed 5 years ago

The feedback form is not centered to the video screen for the standalone client

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
1

Tracking

(firefox34 unaffected, firefox35 fixed, firefox36- fixed, firefox37 fixed)

VERIFIED FIXED
mozilla37
Iteration:
37.1
Tracking Status
firefox34 --- unaffected
firefox35 --- fixed
firefox36 - fixed
firefox37 --- fixed
Blocking Flags:
backlog Fx36+

People

(Reporter: pauly, Unassigned)

References

Details

(Whiteboard: [UX bug])

Attachments

(2 files, 1 obsolete file)

This only affects Rooms, not calls. So it doesn't affect fx34 calling
backlog: --- → Fx35+
Priority: -- → P1
Its currently centred to the page rather than the remote video. IMO, centring it to the remote video would also make it feel awkward.

I think there's two options here:

- Centre it on the remote video
- See if we can display the local video with a grey background, to give a bit more balance.

We probably want UX input here, so NI to Sevaan.
Flags: needinfo?(sfranks)
OS: Windows 7 → All
Hardware: x86_64 → All
[Tracking Requested - why for this release]:
This patch is for the standalone app. We may choose to uplift it for the sake of shared code with desktop.  Marking this as tracking Fx35 so we get this fixed before Fx35 goes to Release.
(In reply to Mark Banner (:standard8) from comment #1)
> Its currently centred to the page rather than the remote video. IMO,
> centring it to the remote video would also make it feel awkward.
> 
> I think there's two options here:
> 
> - Centre it on the remote video
> - See if we can display the local video with a grey background, to give a
> bit more balance.
> 
> We probably want UX input here, so NI to Sevaan.

It should be centers on the remote view, like where the "Join the conversation" button is here: http://cl.ly/image/1o17222g1g2i
Flags: needinfo?(sfranks)
need owner
backlog: Fx35+ → Fx36+
Flags: needinfo?(mreavy)
Whiteboard: [UX bug]
[Tracking Requested - why for this release]:
After triage we've moved this to blocking Fx36 (though we'd love to fix it this week).
Flags: needinfo?(mreavy)
Comment on attachment 8531378 [details] [diff] [review]
Centered feedback form in Loop standalone ended room conversation view.

Review of attachment 8531378 [details] [diff] [review]:
-----------------------------------------------------------------

This breaks the EndedConversationView - according to the ui-showcase.
Attachment #8531378 - Flags: review?(standard8) → review-
Comment on attachment 8531689 [details] [diff] [review]
Centered feedback form in Loop standalone ended room conversation view.

Review of attachment 8531689 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=Standard8
Attachment #8531689 - Flags: review?(standard8) → review+
https://hg.mozilla.org/integration/fx-team/rev/b0c1cd33f0ed
Iteration: --- → 37.1
Points: --- → 1
Target Milestone: --- → mozilla37
https://hg.mozilla.org/mozilla-central/rev/b0c1cd33f0ed
Assignee: nobody → nperriault
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Nicolas, could you fill the uplift request?
Not tracking because it is polishing.
Flags: needinfo?(nperriault)
Comment on attachment 8531689 [details] [diff] [review]
Centered feedback form in Loop standalone ended room conversation view.

Approval Request Comment
[Feature/regressing bug #]: Rooms standalone feedback

[User impact if declined]: merge conflicts in a shared file if we uplift more changes.

[Describe test coverage new/current, TBPL]: manual testing

[Risks and why]: No risk (standalone changes only).

[String/UUID change made/needed]: none
Attachment #8531689 - Flags: approval-mozilla-beta?
Attachment #8531689 - Flags: approval-mozilla-aurora?
Sorry, jetlag killed me.
Flags: needinfo?(nperriault)
Attachment #8531689 - Flags: approval-mozilla-beta?
Attachment #8531689 - Flags: approval-mozilla-beta+
Attachment #8531689 - Flags: approval-mozilla-aurora?
Attachment #8531689 - Flags: approval-mozilla-aurora+
Verified fixed in Chrome and latest nightly using the dev-server.
Status: RESOLVED → VERIFIED
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.