110584 - Missing call to jsj_ExitJava

Status: RESOLVED FIXED

(Core Graveyard :: Java: Live Connect, defect)

Description

[Timothy J. Wood]

JavaArray_newEnumerate has a case statement for the enumation operation.  In the JSENUMERATE_NEXT there is:

    case JSENUMERATE_NEXT:
        index = JSVAL_TO_INT(*statep);
        if (index < array_length) {
            JS_ValueToId(cx, INT_TO_JSVAL(index), idp);
            index++;
            *statep = INT_TO_JSVAL(index);
            return JS_TRUE;
        }


  But, there should be a call to jsj_ExitJava() before the return.  Failure to do so leaves the recursion count on that JSJavaThreadState incorrect (and also screws up my new callbacks).

Comment 1

[Timothy J. Wood]

sorry for the miscategorization on the first pass.  guess I should log a bug against buzilla that the component should start as 'unset' and require being set.

Comment 2

[Boris Zbarsky [:bzbarsky]]

reassing for real

Comment 3

[Phil Schwartau]

Reassigning to Patrick - 

Comment 4

[Kyle Yuan]

taking...

Comment 5

[Kyle Yuan]

Attachment: use |break| instead of |return| in |switch|

so that we won't miss jsj_ExitJava any more.

I checked all other liveconnect code, this is the only place missing
jsj_ExitJava.

Comment 6

[Xiaobin Lu]

Comment on attachment 140406 [details] [diff] [review]
use |break| instead of |return| in |switch|

Looks good to me.

Comment 7

[Brendan Eich [:brendan]]

Comment on attachment 140406 [details] [diff] [review]
use |break| instead of |return| in |switch|

Tradition says the name of that JSBool variable should be "ok", not "result". 
Fix that sr=me.

/be

Comment 8

[Kyle Yuan]

fixed with "result"->"ok" changed.