Closed Bug 1105870 Opened 5 years ago Closed 5 years ago

Fix -Wunused-function warnings-as-errors in nonunified build of dom/canvas

Categories

(Core :: Canvas: WebGL, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37
Tracking Status
firefox35 --- unaffected
firefox36 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

These `IsValidFBO*ColorFormat` functions in dom/canvas/WebGLFramebuffer.cpp are unused, though clang only warns about them in nonunified builds (perhaps clang does less introspection on the huge unified .cpp files). These functions' call points were removed by bug 1102667.

> dom/canvas/WebGLFramebuffer.cpp:224:1: error: unused function 'IsValidFBOTextureColorFormat' [-Werror,-Wunused-function]
> dom/canvas/WebGLFramebuffer.cpp:259:1: error: unused function 'IsValidFBORenderbufferColorFormat' [-Werror,-Wunused-function]
Attachment #8529949 - Flags: review?(jgilbert)
Attachment #8529949 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/d9807bca1e63
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.