If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix -Wunused-function warnings-as-errors in nonunified build of dom/canvas

RESOLVED FIXED in Firefox 36

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

(Blocks: 1 bug)

unspecified
mozilla37
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox35 unaffected, firefox36 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8529949 [details] [diff] [review]
canvas_Wunused-function.patch

These `IsValidFBO*ColorFormat` functions in dom/canvas/WebGLFramebuffer.cpp are unused, though clang only warns about them in nonunified builds (perhaps clang does less introspection on the huge unified .cpp files). These functions' call points were removed by bug 1102667.

> dom/canvas/WebGLFramebuffer.cpp:224:1: error: unused function 'IsValidFBOTextureColorFormat' [-Werror,-Wunused-function]
> dom/canvas/WebGLFramebuffer.cpp:259:1: error: unused function 'IsValidFBORenderbufferColorFormat' [-Werror,-Wunused-function]
Attachment #8529949 - Flags: review?(jgilbert)
Attachment #8529949 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 1

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9807bca1e63
status-firefox36: affected → fixed
https://hg.mozilla.org/mozilla-central/rev/d9807bca1e63
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.