1105871 - "Typing" status panel not cleared if a different tab is selected

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

STR:
1) Open a conversation with someone.
2) Get them to start typing.
3) While they are still typing, switch to a different tab.
4) After they send the message, switch back.
The "<name> is typing..." message is never cleared.

The panel is cleared even if Instantbird doesn't have focus as long as the tab is selected.
I did not test to see what happens when the other party stops typing but doesn't send the message.

Comment 1

[aleth [:aleth]]

Attachment: clearstatuspanel.diff

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8530252 [details] [diff] [review]
clearstatuspanel.diff

Review of attachment 8530252 [details] [diff] [review]:
-----------------------------------------------------------------

This doesn't work: the panel is cleared when switching away from the tab even if the other party is still typing.
For example: if the other guy is typing, and I switch away and switch back before he's done typing, the panel is cleared but it shouldn't be.

Comment 3

[aleth [:aleth]]

Attachment: clearstatuspanel.diff v2

Hopefully this should be better. The main issue was that updateTyping did not update the status panel as as far as it was concerned the typing state of the conversation didn't change merely because the tab was now selected ;)

Please apply the bug blocking this one first to ensure your testing covers the full changed behaviour.

Comment 4

[aleth [:aleth]]

Attachment: clearstatuspanel.diff v3

Use aForceUpdate parameter instead of variable reset, as discussed over IRC.

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8530573 [details] [diff] [review]
clearstatuspanel.diff v3

Review of attachment 8530573 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/b61f86ae229b