Closed Bug 1105894 Opened 9 years ago Closed 9 years ago

Let unified compilation ride the train

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

      No description provided.
Comment on attachment 8529974 [details] [diff] [review]
Let unified compilation ride the train

Review of attachment 8529974 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ -3533,5 @@
>  dnl ========================================================
>  dnl Disable compiling sources in unified mode.
>  dnl ========================================================
>  
> -if test -z "$NIGHTLY_BUILD"; then

IMO it makes sense for the shipped product to look as similar as possible across tree configurations. That means compiling in unified mode everywhere if we do it at all (which we do).

I can't recall why we aren't doing this today. If the reason were important, I'd expect there to be a comment here or in the code commit that introduced it. Neither are present.

I did track down bug 945496 and https://lists.mozilla.org/pipermail/dev-platform/2013-December/002393.html. You might want to link those in the commit message. The reasons there seemed to be stemming from caution and conservatism. I'd like to think things have baked in enough that those are no longer a problem.

r+.
Attachment #8529974 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/9fc2c2ca2395
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.