1105911 - Can't arrow back into location bar once the autocomplete popup has been shown by arrowing down

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[rdz_bug]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20141127030208

Steps to reproduce:

1. type "moz" in the awesome bar
2. keyboard arrow down (you must have at least one search result)
3. keyboard arrow up



Actual results:

selected focus jump to last search result


Expected results:

focus should jump to the awesome bar text input with only "moz"

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 2

[Alice0775 White]

https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=c294ed0b5502&tochange=1791d8198cc3

Comment 3

[:Gijs (he/him)]

I'm pretty sure this got backed out already.

Comment 5

[:Gijs (he/him)]

Ugh. Summary and comment #0 are completely different...

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

there is nothing to track here, we disabled unified complete for now.

Actually I'm not sure IF we want to fix this, the new behavior basically traps the selection in the popup once you enter it, changing that could be problematic, but we'll see.

Comment 7

[Alice0775 White]

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:

(In reply to Marco Bonardo [::mak] (needinfo? me) from comment #6)
> there is nothing to track here, we disabled unified complete for now.
> 
> Actually I'm not sure IF we want to fix this, the new behavior basically
> traps the selection in the popup once you enter it, changing that could be
> problematic, but we'll see.

This problem is reproduced on latest Aurora36.0a2 and Nightly37.0a1 which is disabled unified complete.

https://hg.mozilla.org/releases/mozilla-aurora/rev/94333fbcde0b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141128115136

https://hg.mozilla.org/mozilla-central/rev/17de0f463944
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Firefox/37.0 ID:20141128114334


So, I think this is a valid bug and should be tracking.

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

oops, yes in such a case we need to fix this asap.

I think the problem here is that we override the index handling, but we should do that only if unified is enabled.

Comment 9

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Eep. Indeed.

Comment 10

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8530762 [details] [diff] [review]
Patch v1

Review of attachment 8530762 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/urlbarBindings.xml
@@ +1239,5 @@
>              return -1;
>  
>            let newIndex = index + (reverse ? -1 : 1) * amount;
>  
> +          // We only want to wrap if navigation is in any direction by one item;

s/;/,/

@@ +1246,5 @@
>            // at one end of the list.
> +
> +          if (Services.prefs.getBoolPref("browser.urlbar.unifiedcomplete")) {
> +
> +            if (newIndex < 0) {

nit: I'm not a lover of adding newlines to if/else bodies, while they seem to improve readability (but that's the scope of indentation) they greatly reduce visible context.

Comment 12

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/integration/fx-team/rev/0e6026de7539

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0e6026de7539

Comment 14

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

this should be uplifted to Aurora. Care to ask for approval please?

Comment 15

[Andrei Vaida [:avaida]]

Verified fixed on Nightly 37.0a1 (2014-12-07) using Windows 7 64-bit, Ubuntu 14.04 LTS 32-bit and Mac OS X 10.9.5.

I'll keep an eye on this for when it lands on m-a.

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Blair, could you fill the uplift request? Thanks

Comment 17

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8530762 [details] [diff] [review]
Patch v1

Approval Request Comment
[Feature/regressing bug #]: bug 1067903
[User impact if declined]: Unable to have no URLBar autocomplete item selected, after selecting first item
[Describe test coverage new/current, TBPL]: Unit test, few days on the tree
[Risks and why]: Low risk - restoring previous functionality & code.
[String/UUID change made/needed]: None

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2d389b81fc82

Comment 19

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this bug on Firefox 36.0a1 (2014-11-27) using Windows 7 x64.

Verified fixed on Latest Firefox 36.0a2 (2014-12-11) using Windows 7 x64, Ubuntu 14.04 x86 and Mac OSX 10.9.5.