Closed
Bug 1105911
Opened 10 years ago
Closed 10 years ago
Can't arrow back into location bar once the autocomplete popup has been shown by arrowing down
Categories
(Firefox :: Address Bar, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox35 | --- | unaffected |
firefox36 | + | verified |
firefox37 | + | verified |
People
(Reporter: rodrigozeh, Assigned: Unfocused)
References
Details
(Keywords: regression)
Attachments
(1 file)
6.85 KB,
patch
|
mak
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20141127030208
Steps to reproduce:
1. type "moz" in the awesome bar
2. keyboard arrow down (you must have at least one search result)
3. keyboard arrow up
Actual results:
selected focus jump to last search result
Expected results:
focus should jump to the awesome bar text input with only "moz"
![]() |
||
Comment 1•10 years ago
|
||
[Tracking Requested - why for this release]:
Status: UNCONFIRMED → NEW
status-firefox35:
--- → unaffected
status-firefox36:
--- → affected
tracking-firefox36:
--- → ?
Component: Untriaged → Location Bar
Ever confirmed: true
![]() |
||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=c294ed0b5502&tochange=1791d8198cc3
Blocks: 1067903
Keywords: regression
![]() |
||
Updated•10 years ago
|
Flags: needinfo?(bmcbride)
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(mak77)
Flags: needinfo?(bmcbride)
Resolution: --- → DUPLICATE
Comment 5•10 years ago
|
||
Ugh. Summary and comment #0 are completely different...
Status: RESOLVED → REOPENED
Flags: needinfo?(mak77)
Flags: needinfo?(bmcbride)
Resolution: DUPLICATE → ---
Summary: awesome bar losing typed text → Can't arrow back into location bar once the autocomplete popup has been shown by arrowing down
Comment 6•10 years ago
|
||
there is nothing to track here, we disabled unified complete for now.
Actually I'm not sure IF we want to fix this, the new behavior basically traps the selection in the popup once you enter it, changing that could be problematic, but we'll see.
Updated•10 years ago
|
Flags: needinfo?(bmcbride)
![]() |
||
Comment 7•10 years ago
|
||
[Tracking Requested - why for this release]:
[Tracking Requested - why for this release]:
[Tracking Requested - why for this release]:
(In reply to Marco Bonardo [::mak] (needinfo? me) from comment #6)
> there is nothing to track here, we disabled unified complete for now.
>
> Actually I'm not sure IF we want to fix this, the new behavior basically
> traps the selection in the popup once you enter it, changing that could be
> problematic, but we'll see.
This problem is reproduced on latest Aurora36.0a2 and Nightly37.0a1 which is disabled unified complete.
https://hg.mozilla.org/releases/mozilla-aurora/rev/94333fbcde0b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141128115136
https://hg.mozilla.org/mozilla-central/rev/17de0f463944
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Firefox/37.0 ID:20141128114334
So, I think this is a valid bug and should be tracking.
status-firefox37:
--- → affected
tracking-firefox36:
--- → ?
tracking-firefox37:
--- → ?
Flags: needinfo?(mak77)
Comment 8•10 years ago
|
||
oops, yes in such a case we need to fix this asap.
I think the problem here is that we override the index handling, but we should do that only if unified is enabled.
Flags: needinfo?(mak77) → needinfo?(bmcbride)
Assignee | ||
Comment 9•10 years ago
|
||
Eep. Indeed.
Assignee: nobody → bmcbride
Status: REOPENED → ASSIGNED
Points: --- → 3
Flags: needinfo?(bmcbride) → firefox-backlog+
Updated•10 years ago
|
Updated•10 years ago
|
Iteration: --- → 37.1
Flags: qe-verify?
Assignee | ||
Comment 10•10 years ago
|
||
Attachment #8530762 -
Flags: review?(mak77)
Comment 11•10 years ago
|
||
Comment on attachment 8530762 [details] [diff] [review]
Patch v1
Review of attachment 8530762 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/base/content/urlbarBindings.xml
@@ +1239,5 @@
> return -1;
>
> let newIndex = index + (reverse ? -1 : 1) * amount;
>
> + // We only want to wrap if navigation is in any direction by one item;
s/;/,/
@@ +1246,5 @@
> // at one end of the list.
> +
> + if (Services.prefs.getBoolPref("browser.urlbar.unifiedcomplete")) {
> +
> + if (newIndex < 0) {
nit: I'm not a lover of adding newlines to if/else bodies, while they seem to improve readability (but that's the scope of indentation) they greatly reduce visible context.
Attachment #8530762 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 12•10 years ago
|
||
Comment 13•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Comment 14•10 years ago
|
||
this should be uplifted to Aurora. Care to ask for approval please?
Comment 15•10 years ago
|
||
Verified fixed on Nightly 37.0a1 (2014-12-07) using Windows 7 64-bit, Ubuntu 14.04 LTS 32-bit and Mac OS X 10.9.5.
I'll keep an eye on this for when it lands on m-a.
Comment 16•10 years ago
|
||
Blair, could you fill the uplift request? Thanks
Flags: needinfo?(bmcbride)
Flags: in-testsuite+
Updated•10 years ago
|
Assignee | ||
Comment 17•10 years ago
|
||
Comment on attachment 8530762 [details] [diff] [review]
Patch v1
Approval Request Comment
[Feature/regressing bug #]: bug 1067903
[User impact if declined]: Unable to have no URLBar autocomplete item selected, after selecting first item
[Describe test coverage new/current, TBPL]: Unit test, few days on the tree
[Risks and why]: Low risk - restoring previous functionality & code.
[String/UUID change made/needed]: None
Flags: needinfo?(bmcbride)
Attachment #8530762 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #8530762 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 18•10 years ago
|
||
Comment 19•10 years ago
|
||
I was able to reproduce this bug on Firefox 36.0a1 (2014-11-27) using Windows 7 x64.
Verified fixed on Latest Firefox 36.0a2 (2014-12-11) using Windows 7 x64, Ubuntu 14.04 x86 and Mac OSX 10.9.5.
You need to log in
before you can comment on or make changes to this bug.
Description
•