Closed Bug 1105981 Opened 10 years ago Closed 10 years ago

[Stingray][Home] Rename card

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rexboy, Assigned: rexboy)

References

Details

(Whiteboard: [ft:conndevices] [ETA:1/23] [Stingray-Branch][picked 1/30])

Attachments

(1 file)

Under edit mode, - Pressing the rename button should enter the card renaming phase. - After user finish editing the name, it should save the new name on the card.
Assignee: nobody → rexboy
Deassign since I can't work on it until Jan. 5. If nobody pick it until that time I'll take it back.
Assignee: rexboy → nobody
Assignee: nobody → rexboy
Whiteboard: [ft:conndevices] → [ft:conndevices] [ETA:1/23]
Whiteboard: [ft:conndevices] [ETA:1/23] → [ft:conndevices] [ETA:1/23] [Stingray-Branch]
Whiteboard: [ft:conndevices] [ETA:1/23] [Stingray-Branch] → [ft:conndevices] [ETA:1/23]
Attached file Patch
This PR contains two patches. please review the commit just for this bug. John would you review the part of system app; And Tzu-lin may you take a look on the card_manager changes? Thanks!
Attachment #8552958 - Flags: review?(im)
Attachment #8552958 - Flags: feedback?(tzhuang)
Comment on attachment 8552958 [details] [review] Patch In card_manager.js, I think we need to touch this._cardList before calling this.writeCardlistInCardStore(). Otherwise the updated card will not get written into datastore. Please send me feedback request again if you finish this part. Thanks
Attachment #8552958 - Flags: feedback?(tzhuang)
Comment on attachment 8552958 [details] [review] Patch For smart-system part, it looks ok. But please update the code based on our discussion at this morning. I had put some comments at PR. Please check them, too.
Attachment #8552958 - Flags: review?(im) → review+
Comment on attachment 8552958 [details] [review] Patch Hi Tzu-lin, I've changed the code. Would you take a look again?
Attachment #8552958 - Flags: feedback?(tzhuang)
Comment on attachment 8552958 [details] [review] Patch Card manager part looks good to me. Thanks
Attachment #8552958 - Flags: feedback?(tzhuang) → feedback+
Hi Rex, please land and we can close this, thanks
Flags: needinfo?(rexboy)
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(rexboy)
Resolution: --- → FIXED
Whiteboard: [ft:conndevices] [ETA:1/23] → [ft:conndevices] [ETA:1/23] [Stingray-Branch][picked 1/30]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: