1105981 - [Stingray][Home] Rename card

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Under edit mode,
- Pressing the rename button should enter the card renaming phase.
- After user finish editing the name, it should save the new name on the card.

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Deassign since I can't work on it until Jan. 5.
If nobody pick it until that time I'll take it back.

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Patch

This PR contains two patches. please review the commit just for this bug.

John would you review the part of system app;
And Tzu-lin may you take a look on the card_manager changes?
Thanks!

Comment 3

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8552958 [details] [review]
Patch

In card_manager.js, I think we need to touch this._cardList before calling this.writeCardlistInCardStore(). Otherwise the updated card will not get written into datastore.

Please send me feedback request again if you finish this part. Thanks

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8552958 [details] [review]
Patch

For smart-system part, it looks ok. But please update the code based on our discussion at this morning. I had put some comments at PR. Please check them, too.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8552958 [details] [review]
Patch

Hi Tzu-lin, I've changed the code. Would you take a look again?

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8552958 [details] [review]
Patch

Card manager part looks good to me. Thanks

Comment 7

[howie [:howie]]

Hi Rex, please land and we can close this, thanks

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

https://github.com/mozilla-b2g/gaia/commit/51700f9393ba2779b25c1ad329c369209d905570