1106017 - [Bluetooth] Port Bug 1105308 to bluetooth2

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Comment 1

[Ben Tian (inactive)]

Thomas, do you mind my stealing this bug? I'd like to fix bluetooth2 emulator build break (bug 1128797) based on this bug.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

No, not at all. Please go forward.

Comment 3

[Ben Tian (inactive)]

Attachment: Patch 1 (v1): Cleanup non-shared functions in BlueZ' BluetoothUtils.{cpp,h}

The patch is the same as patch [01] in bug 1105308.

Comment 4

[Ben Tian (inactive)]

Attachment: Patch 2 (v1): Merge BluetoothUtils.{cpp,h}

The patch is the same as patch [03] in bug 1105308.

Comment 5

[Ben Tian (inactive)]

Note patch [02] in bug 1105308 is not required for bluetooth2 has no function |UuidToServiceClassInt|.

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8558421 [details] [diff] [review]
Patch 1 (v1): Cleanup non-shared functions in BlueZ' BluetoothUtils.{cpp,h}

Review of attachment 8558421 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8558424 [details] [diff] [review]
Patch 2 (v1): Merge BluetoothUtils.{cpp,h}

Review of attachment 8558424 [details] [diff] [review]:
-----------------------------------------------------------------

Also looks good. Thanks for doing the merge.

Comment 8

[Ben Tian (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/e263c706bbc6
https://hg.mozilla.org/integration/b2g-inbound/rev/519ac008276a

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e263c706bbc6
https://hg.mozilla.org/mozilla-central/rev/519ac008276a